A build should work out of the box and not require 2 weeks of first fixing sporadically broken unit tests.
And a release usually should be $> mvn release:prepare $> mvn release:perform that's it. Everything else is not really user friendly and will make it harder for any new committer to get on board. I get the argument test coverage. But some of these examples still use the javaee6 apis, etc... LieGrue, strub > Am 20.06.2018 um 06:48 schrieb Romain Manni-Bucau <[email protected]>: > > Dropping the example will require to move their tests in the main chain > since they are part of our coverage. > > Also note you probably dont want to use release plugin cause running the > test (with -Pall-adapters if you respect the plugin philosophy) is quite > long (should be ~3h x2). Just tag and deploy manually from a green build on > the CI, this is more reliable for tomee. > > Le mer. 20 juin 2018 00:14, Jonathan Gallimore <[email protected]> > a écrit : > >> Sure, I'll take a look tomorrow morning. >> >> On Tue, 19 Jun 2018, 21:57 Mark Struberg, <[email protected]> >> wrote: >> >>> it's license is ALv2, so not a biggie. >>> Do you put it onto your list, Jon? >>> txs and LieGrue,strub >>> >>> On Tuesday, 19 June 2018, 22:11:23 CEST, Jonathan Gallimore < >>> [email protected]> wrote: >>> >>> Definitely a left over, they should be self contained. >>> >>> Jon >>> >>> On Tue, 19 Jun 2018, 21:04 Mark Struberg, <[email protected]> >>> wrote: >>> >>>> while fixing the versions of almost all our examples I found the >>>> following parent pom >>>> <parent> >>>> <groupId>org.tomitribe</groupId> >>>> <artifactId>oss-parent</artifactId> >>>> <version>2</version> >>>> </parent> >>>> >>>> >>>> do we really want this?I thought our examples should be self-contained, >>>> isn't? >>>> Guess that's just an oversight and a leftover from a code donation? >>>> txs and LieGrue,strub >>>> >>>> On Tuesday, 19 June 2018, 21:49:40 CEST, Mark Struberg >>>> <[email protected]> wrote: >>>> >>>> And blowing up badly :( >>>> >>>> >>>> [ERROR] Failed to execute goal >>>> org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare >> (default-cli) >>>> on project tomee-project: The version could not be updated: >>>> ${tomee.version} -> [Help 1] >>>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to >> execute >>>> goal org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare >>>> (default-cli) on project tomee-project: The version could not be >> updated: >>>> ${tomee.version} >>>> >>>> >>>> >>>> On Tuesday, 19 June 2018, 21:15:06 CEST, Mark Struberg >>>> <[email protected]> wrote: >>>> >>>> Rolling a 7.0.5 release now. >>>> >>>> Doing this on my linux box, so I hope I didn't forget to setup >> anything. >>>> LieGrue,strub >>>> >>> >>
