The unit tests point is likely easy to solve either using another pool or just not using a pool for tests. Also the bug you fixed happens under some particular case we can workaround using bigger pools I think. Asm upgrade is really a few seds (I can help end of next week - thursday I think - if needed).
Overall point was to not lock an ecosystem for features not used in half of it. Commons-[pool|dbcp] is not required dependency of openjpa so shouldnt block its release and if it does we must work to fix that issue IMHO. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le dim. 11 nov. 2018 à 12:11, Mark Struberg <strub...@yahoo.de.invalid> a écrit : > The problem is that the unit tests in OpenJPA do not pass with the old > pool. > So for getting OpenJPA-3.0.1 we need commons-pool. > OpenJPA-3.0.0 still uses xbean-asm6. Means different package.We would need > to package both xbean-asm6 and xbean-asm7 if we want to ship TomEE with > OpenJPA-3.0.0. > LieGrue,strub > > On Saturday, 10 November 2018, 22:52:48 CET, Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > > Agreed. Probably we don't need to wait for it. At least we could do a M2 > which is Java 11 ready. > > > > Le sam. 10 nov. 2018 à 21:49, Romain Manni-Bucau <rmannibu...@gmail.com> a > écrit : > > > Shouldnt be the case Mark since openjpa is not bound to a pool - except > in > > tests - and tomee default pool is not dbcp2 but tomcat-jdbc. So it is > not a > > requirement but more a nice to have IMHO. Also not a regression since > last > > release so not a blocker ;). > > > > > > Le sam. 10 nov. 2018 21:02, Mark Struberg <strub...@yahoo.de.invalid> a > > écrit : > > > > > We also need to wait for commons-pool and commons-dbcp. I fixed a > > > deadlock in the pool.Only after that I'll be able to release OpenJPA. > > > LieGrue,strub > > > > > > On Friday, 9 November 2018, 21:02:13 CET, Mark Struberg > > > <strub...@yahoo.de.INVALID> wrote: > > > > > > Right now I do a lot of OpenJPA hacking. > > > One of the tasks is to also support xbean-asm7. > > > That should go into openjpa-3.0.1. > > > > > > What is the timeframe we want to target? > > > > > > LieGrue, > > > strub > > > > > > > > > > Am 09.11.2018 um 14:18 schrieb Romain Manni-Bucau < > > rmannibu...@gmail.com > > > >: > > > > > > > > I don't have the list handy but tomee will need at least some > > --add-opens > > > > etc to run on java11 (you can add it in setenv.sh) - likely for > unsafe > > > and > > > > the agent. > > > > > > > > Romain Manni-Bucau > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > > > <https://rmannibucau.metawerx.net/> | Old Blog > > > > <http://rmannibucau.wordpress.com> | Github < > > > https://github.com/rmannibucau> | > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > > > < > > > > > > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > > > > > > > > > > > > Le ven. 9 nov. 2018 à 14:09, Thomas Andraschko < > > > andraschko.tho...@gmail.com> > > > > a écrit : > > > > > > > >> (e.g. Tomcat and DeltaSpike still uses the old namespace it's in > > > >> web/beans.xml) > > > >> > > > >> Am Fr., 9. Nov. 2018 um 13:35 Uhr schrieb Thomas Andraschko < > > > >> andraschko.tho...@gmail.com>: > > > >> > > > >>> Also looks like XML unmarshalling is broken: > > > >>> > > > >>> Caused by: javax.xml.bind.UnmarshalException: unerwartetes Element > > > (URI:" > > > >>> http://java.sun.com/xml/ns/javaee";, lokal:"interceptors"). > Erwartete > > > >>> Elemente > > > >>> sind > > <{}trim>,<{}decorators>,<{}scan>,<{}alternatives>,<{}interceptors> > > > >>> at > > > >>> > > > > com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallingContext.handleEvent > > > >>> (UnmarshallingContext.java:744) > > > >>> at com.sun.xml.bind.v2.runtime.unmarshaller.Loader.reportError > > > >>> (Loader.java:262) > > > >>> at com.sun.xml.bind.v2.runtime.unmarshaller.Loader.reportError > > > >>> (Loader.java:257) > > > >>> at > > > >>> > > > >> > > > > > > com.sun.xml.bind.v2.runtime.unmarshaller.Loader.reportUnexpectedChildElement > > > >>> (Loader.java:124) > > > >>> at com.sun.xml.bind.v2.runtime.unmarshaller.Loader.childElement > > > >>> (Loader.java:105) > > > >>> at > > > >>> > com.sun.xml.bind.v2.runtime.unmarshaller.StructureLoader.childElement > > > >>> (StructureLoader.java:268) > > > >>> at > > > >>> > > > >> > > > > > > com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallingContext._startElement > > > >>> (UnmarshallingContext.java:574) > > > >>> at > > > >>> > > > >> > > > > > > com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallingContext.startElement > > > >>> (UnmarshallingContext.java:556) > > > >>> at > > > com.sun.xml.bind.v2.runtime.unmarshaller.SAXConnector.startElement > > > >>> (SAXConnector.java:168) > > > >>> at org.xml.sax.helpers.XMLFilterImpl.startElement > > > >>> (XMLFilterImpl.java:551) > > > >>> at > > > >>> > org.apache.openejb.jee.JaxbJavaee$JavaeeNamespaceFilter.startElement > > > >>> (JaxbJavaee.java:293) > > > >>> at > > > >>> > > > > com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement > > > >>> (AbstractSAXParser.java:510) > > > >>> at > > > >>> > > > >> > > > > > > com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement > > > >>> (XMLNSDocumentScannerImpl.java:374) > > > >>> at > > > >>> > > > >> > > > > > > com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next > > > >>> (XMLDocumentFragmentScannerImpl.java:2708) > > > >>> at > > > >> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next > > > >>> (XMLDocumentScannerImpl.java:605) > > > >>> at > > > >>> > com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next > > > >>> (XMLNSDocumentScannerImpl.java:112) > > > >>> at > > > >>> > > > >> > > > > > > com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument > > > >>> (XMLDocumentFragmentScannerImpl.java:534) > > > >>> at > > > >> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse > > > >>> (XML11Configuration.java:888) > > > >>> at > > > >> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse > > > >>> (XML11Configuration.java:824) > > > >>> at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse > > > >>> (XMLParser.java:141) > > > >>> at > > > com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse > > > >>> (AbstractSAXParser.java:1216) > > > >>> at > > > >>> > > > > com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse > > > >>> (SAXParserImpl.java:635) > > > >>> at org.xml.sax.helpers.XMLFilterImpl.parse > > (XMLFilterImpl.java:357) > > > >>> at > > > >>> > com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal0 > > > >>> (UnmarshallerImpl.java:258) > > > >>> at > > > >> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal > > > >>> (UnmarshallerImpl.java:236) > > > >>> at > > > >> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal > > > >>> (UnmarshallerImpl.java:288) > > > >>> at org.apache.openejb.jee.JaxbJavaee.unmarshalJavaee > > > >>> (JaxbJavaee.java:133) > > > >>> at org.apache.openejb.config.ReadDescriptors.readBeans > > > >>> (ReadDescriptors.java:691) > > > >>> at org.apache.openejb.config.DeploymentLoader.mergeBeansXml > > > >>> (DeploymentLoader.java:1196) > > > >>> at org.apache.openejb.config.DeploymentLoader.addBeansXmls > > > >>> (DeploymentLoader.java:1184) > > > >>> at org.apache.openejb.config.DeploymentLoader.createWebModule > > > >>> (DeploymentLoader.java:1098) > > > >>> at org.apache.openejb.config.DeploymentLoader.createWebModule > > > >>> (DeploymentLoader.java:823) > > > >>> at org.apache.openejb.config.DeploymentLoader.load > > > >>> (DeploymentLoader.java:234) > > > >>> at org.apache.tomee.catalina.TomcatWebAppBuilder.loadApplication > > > >>> (TomcatWebAppBuilder.java:2347) > > > >>> at org.apache.tomee.catalina.TomcatWebAppBuilder.startInternal > > > >>> (TomcatWebAppBuilder.java:1197) > > > >>> at org.apache.tomee.catalina.TomcatWebAppBuilder.configureStart > > > >>> (TomcatWebAppBuilder.java:1130) > > > >>> at > org.apache.tomee.catalina.GlobalListenerSupport.lifecycleEvent > > > >>> (GlobalListenerSupport.java:133) > > > >>> at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent > > > >>> (LifecycleBase.java:123) > > > >>> > > > >>> > > > >>> > > > >>> Am Fr., 9. Nov. 2018 um 13:27 Uhr schrieb Thomas Andraschko < > > > >>> andraschko.tho...@gmail.com>: > > > >>> > > > >>>> @Jean-Louis > > > >>>> Are you saying that TomEE8 M1 itself is not compatbile with > Java11? > > > >>>> > > > >>>> Currently trying to run my application with tomee-maven-embedded > and > > > it > > > >>>> fails: > > > >>>> java.lang.IllegalStateException: Unable to initialize agent > > > >>>> at > > > >>>> > > org.apache.openejb.javaagent.Agent.checkInitialization(Agent.java:104) > > > >>>> at > > > >>>> > org.apache.openejb.javaagent.Agent.getInstrumentation(Agent.java:94) > > > >>>> at > > > >>>> org.apache.tomee.embedded.Container.<clinit>(Container.java:128) > > > >>>> at > > > >>>> > > > >> > > > > > > org.apache.openejb.maven.plugins.TomEEEmbeddedMojo.execute(TomEEEmbeddedMojo.java:392) > > > >>>> at > > > >>>> > > > >> > > > > > > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) > > > >>>> > > > >>>> > > > >>>> Am Do., 8. Nov. 2018 um 21:36 Uhr schrieb Romain Manni-Bucau < > > > >>>> rmannibu...@gmail.com>: > > > >>>> > > > >>>>> Hi JL > > > >>>>> > > > >>>>> Openjpa needs xbean upgrade but should be quick. Cxf stack needs > > some > > > >>>>> jaxb > > > >>>>> upgrades from memory. After the stack "supports" java11 as "run > it" > > > but > > > >>>>> think no spec in EE is java >= 9 compatible (modules, spi etc). > > > >>>>> > > > >>>>> Should be enough for tomee that said. > > > >>>>> > > > >>>>> > > > >>>>> Le jeu. 8 nov. 2018 20:27, Jean-Louis Monteiro < > > > >> jlmonte...@tomitribe.com> > > > >>>>> a > > > >>>>> écrit : > > > >>>>> > > > >>>>>> Hey TomEE lovers, > > > >>>>>> > > > >>>>>> I would like to push the Java 11 support forward. > > > >>>>>> > > > >>>>>> I tried to gather information here and there. Here is a status > > with > > > >> my > > > >>>>>> view. Please, lemme know if you have further updates or any > > > >> additional > > > >>>>>> information. > > > >>>>>> > > > >>>>>> XBean: ready and released > > > >>>>>> OWB: ready and released > > > >>>>>> TomEE itself (OpenEJB and other integration): ready but not > > released > > > >>>>> yet > > > >>>>>> OpenJPA: not clear, but looks like there is still some work to > be > > > >> done > > > >>>>>> CXF: ready and released > > > >>>>>> MyFaces, ActiveMQ, EclipseLink, Mojorra: unknown > > > >>>>>> Tomcat: ready and released > > > >>>>>> > > > >>>>>> Are we on the same page? > > > >>>>>> > > > >>>>>> I propose to reach out to communities when libraries are not yet > > > >> ready > > > >>>>> or > > > >>>>>> released and see how we can help. > > > >>>>>> > > > >>>>>> Thoughts? > > > >>>>>> > > > >>>>>> -- > > > >>>>>> Jean-Louis Monteiro > > > >>>>>> http://twitter.com/jlouismonteiro > > > >>>>>> http://www.tomitribe.com > > > >>>>>> > > > >>>>> > > > >>>> > > > >> > > > > >
