Thanks, Guys! I really don't see the point in squashing commits as you describe it. Seems like it cooks the books on what is actually being done. Not sure why anyone would care if a PR has multiple commits. In fact, that would make it far easier to evaluate the PR, I believe. Anyway, I get it now and I thank everyone for stepping up to explain it to me but unless there is some mandate for it, I won't be squashing commits.
On Fri, Nov 30, 2018 at 8:55 AM Romain Manni-Bucau <rmannibu...@gmail.com> wrote: > Hi Richard, > > if you have 3 commit in your PR you create a single one "squashing" them 3 > (or you can select just 2 if you want) > > Some people are fan of it, some people hate it cause it break the history > and the "thinking" of the devs so you loose precious information (yes i'm > in this last part....being said at the end you can't rely on the history > whatever effort you put in the writing of it). I have a colleague who is > quite interesting on that, he says "I squash 'fix typo' commits only". > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <https://rmannibucau.metawerx.net/> | Old Blog > <http://rmannibucau.wordpress.com> | Github < > https://github.com/rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > < > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > Le ven. 30 nov. 2018 à 15:50, Richard Monson-Haefel < > monsonhae...@gmail.com> > a écrit : > > > Hi, > > > > What does "Squashing your PR" mean? > > > > Thank you! > > > > Richard > > > > On Thu, Nov 29, 2018 at 5:00 PM exabrial12 <exabr...@gmail.com> wrote: > > > > > Also, if you don't mind Squashing your PR before submitting the > request, > > > that > > > will help port anything to other branches! > > > > > > > > > > > > -- > > > Sent from: > > > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html > > > > > > > > > -- > > Richard Monson-Haefel > > https://twitter.com/rmonson > > https://www.linkedin.com/in/monsonhaefel/ > > > -- Richard Monson-Haefel https://twitter.com/rmonson https://www.linkedin.com/in/monsonhaefel/
