I appreciate that. Can I ask you be mindful that Frankie posted, and I asked him if he wanted to have a go in my reply? We should give him some time to respond, before someone else picks it up. If Frankie worked on fixing those, and then found someone else had done the same work without a JIRA, I suspect that would be pretty frustrating.
Jon On Wed, Dec 5, 2018 at 12:03 PM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > I can help fixing some of those > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > Hi, > > > > Great question. The commands are: > > > > Checkstyle: mvn -Pstyle checkstyle:check > > PMD: mvn -Pstyle pmd:check > > > > These are relatively quick to run - about a minute or so. > > > > Looks like we have 2 checkstyle violations in the build at the moment: > > > > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio > > > > [INFO] There are 2 errors reported by Checkstyle 6.1.1 with > > > > > /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml > > ruleset. > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8] > > (imports) UnusedImports: Unused import - > > org.apache.openejb.loader.SystemClassPath. > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15] > > (imports) UnusedImports: Unused import - > > org.apache.openejb.loader.JarLocation.jarLocation. > > > > Frankie, would you like to have a go at resolving these? > > > > Cheers > > > > Jon > > > > On Wed, Dec 5, 2018 at 6:50 AM Frankie <kamin.feuer.2...@gmx.de> wrote: > > > > > What can I do to already detect such problems when I work on the code? > > > What is the difference on the build system? (additional checkstyle > rules > > > ...? > > > > > > Frankie > > > > > > > > > > > > -- > > > Sent from: > > > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html > > > > > >
