Filed a ticket for bval failures and will work on that next. https://issues.apache.org/jira/browse/TOMEE-2327
Jon On Thu, Dec 6, 2018 at 3:31 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Hopefully this will do the trick: https://github.com/apache/tomee/pull/258. > Full build currently running here. > > Jon > > On Thu, Dec 6, 2018 at 10:46 AM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > >> I believe this is the root cause of these test failures: >> >> WARNING: Failed to invoke bootstrap: >> javax/persistence/spi/PersistenceUnitInfo >> >> Exception in thread "main" java.lang.NoClassDefFoundError: >> org/apache/commons/cli/ParseException >> >> at java.lang.Class.getDeclaredConstructors0(Native Method) >> >> at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671) >> >> at java.lang.Class.getConstructor0(Class.java:3075) >> >> at java.lang.Class.getConstructor(Class.java:1825) >> >> at org.apache.openejb.cli.Bootstrap.main(Bootstrap.java:155) >> >> Caused by: java.lang.ClassNotFoundException: >> org.apache.commons.cli.ParseException >> >> at java.net.URLClassLoader.findClass(URLClassLoader.java:381) >> >> at java.lang.ClassLoader.loadClass(ClassLoader.java:424) >> >> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338) >> >> at java.lang.ClassLoader.loadClass(ClassLoader.java:357) >> >> ... 5 more >> >> >> and its been introduced in this PR: >> https://github.com/apache/tomee/pull/176 (I pulled the 8.0.0-M1 tag, >> where this was working, and applied this PR to it in my working copy, and >> it now fails). >> >> >> Digging in to see if I can fix it. Dani, any thoughts you have are >> appreciated. >> >> >> Jon >> >> On Wed, Dec 5, 2018 at 9:44 PM Jonathan Gallimore < >> jonathan.gallim...@gmail.com> wrote: >> >>> Looks like we have some new failures in the itest module: >>> >>> [ERROR] RandomConnectionStrategyTest.test:162 » Naming Cannot lookup >>> '/CalculatorBeanR... >>> >>> [ERROR] ReconnectDelayCaseInsensitiveTest.test:150 » Naming Cannot >>> lookup '/Calculator... >>> >>> [ERROR] ReconnectDelayListSelfTest.test:150 » Naming Cannot lookup >>> '/CalculatorBeanRem... >>> >>> [ERROR] ReconnectDelayTest.test:131 » Naming Cannot lookup >>> '/CalculatorBeanRemote'. >>> >>> [ERROR] RoundRobinConnectionStrategyTest.test:164 » Naming Cannot >>> lookup '/CalculatorB... >>> >>> [ERROR] StickyConnectionStrategyTest.test:146->invoke:225 » Naming >>> Cannot lookup '/Cal... >>> >>> >>> I'll take a look. JIRA is: >>> https://issues.apache.org/jira/browse/TOMEE-2322. >>> >>> >>> Cheers >>> >>> >>> Jon >>> >>> On Wed, Dec 5, 2018 at 12:39 PM Jean-Louis Monteiro < >>> jlmonte...@tomitribe.com> wrote: >>> >>>> Oups, then I believe I need to apologize guys. >>>> >>>> I wanted to at least fix the 2 imports so we can get a build with some >>>> results. >>>> >>>> -- >>>> Jean-Louis Monteiro >>>> http://twitter.com/jlouismonteiro >>>> http://www.tomitribe.com >>>> >>>> >>>> On Wed, Dec 5, 2018 at 1:24 PM Jonathan Gallimore < >>>> jonathan.gallim...@gmail.com> wrote: >>>> >>>> > I appreciate that. Can I ask you be mindful that Frankie posted, and I >>>> > asked him if he wanted to have a go in my reply? We should give him >>>> some >>>> > time to respond, before someone else picks it up. If Frankie worked on >>>> > fixing those, and then found someone else had done the same work >>>> without a >>>> > JIRA, I suspect that would be pretty frustrating. >>>> > >>>> > Jon >>>> > >>>> > On Wed, Dec 5, 2018 at 12:03 PM Jean-Louis Monteiro < >>>> > jlmonte...@tomitribe.com> wrote: >>>> > >>>> > > I can help fixing some of those >>>> > > >>>> > > -- >>>> > > Jean-Louis Monteiro >>>> > > http://twitter.com/jlouismonteiro >>>> > > http://www.tomitribe.com >>>> > > >>>> > > >>>> > > On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore < >>>> > > jonathan.gallim...@gmail.com> wrote: >>>> > > >>>> > > > Hi, >>>> > > > >>>> > > > Great question. The commands are: >>>> > > > >>>> > > > Checkstyle: mvn -Pstyle checkstyle:check >>>> > > > PMD: mvn -Pstyle pmd:check >>>> > > > >>>> > > > These are relatively quick to run - about a minute or so. >>>> > > > >>>> > > > Looks like we have 2 checkstyle violations in the build at the >>>> moment: >>>> > > > >>>> > > > >>>> > > >>>> > >>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio >>>> > > > >>>> > > > [INFO] There are 2 errors reported by Checkstyle 6.1.1 with >>>> > > > >>>> > > > >>>> > > >>>> > >>>> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml >>>> > > > ruleset. >>>> > > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8] >>>> > > > (imports) UnusedImports: Unused import - >>>> > > > org.apache.openejb.loader.SystemClassPath. >>>> > > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15] >>>> > > > (imports) UnusedImports: Unused import - >>>> > > > org.apache.openejb.loader.JarLocation.jarLocation. >>>> > > > >>>> > > > Frankie, would you like to have a go at resolving these? >>>> > > > >>>> > > > Cheers >>>> > > > >>>> > > > Jon >>>> > > > >>>> > > > On Wed, Dec 5, 2018 at 6:50 AM Frankie <kamin.feuer.2...@gmx.de> >>>> > wrote: >>>> > > > >>>> > > > > What can I do to already detect such problems when I work on the >>>> > code? >>>> > > > > What is the difference on the build system? (additional >>>> checkstyle >>>> > > rules >>>> > > > > ...? >>>> > > > > >>>> > > > > Frankie >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > -- >>>> > > > > Sent from: >>>> > > > > >>>> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html >>>> > > > > >>>> > > > >>>> > > >>>> > >>>> >>>
