Hi Ivan, I have made the changes requested and I've some questions regarding the spec which I've asked on the github thread, can you please clarify these?
On Wed 2 Jan, 2019, 6:09 PM Ivan Junckes Filho <[email protected] wrote: > Puneeth, I did some comments here > https://github.com/apache/tomee/pull/340#pullrequestreview-188661807, > please take a look. > > On Wed, Jan 2, 2019 at 9:51 AM Ivan Junckes Filho <[email protected]> > wrote: > > > Hi Puneeth, I will review it for you. > > > > On Wed, Jan 2, 2019 at 8:39 AM Puneeth PS <[email protected]> wrote: > > > >> Hi, > >> > >> I have created a PR ( https://github.com/apache/tomee/pull/340 ) for > >> TOMEE-2289. Can someone take a look and help me improve it? > >> > > >
