I will take a look and help troubleshoot this.

On Thu, Jan 3, 2019 at 12:08 PM Puneeth PS <[email protected]> wrote:

> Hi Ivan,
>
> /openapi works in POSTMAN client but not on browser, so might not be an
> issue.
>
> On Thu, Jan 3, 2019 at 6:38 PM Ivan Junckes Filho <[email protected]>
> wrote:
>
> > Hi Puneeth, I added a couple of more comments.
> >
> > There seems to have a couple of bugs in the openapi implementation.
> >
> > Json serialization bug and also /openapi is not working without the
> header.
> > So we may need to open bugs
> > in https://issues.apache.org/jira/projects/GERONIMO/issues
> > <https://issues.apache.org/jira/projects/GERONIMO/issues>.
> >
> > I will try to help troubleshoot these issues.
> >
> >
> >
> >
> > On Thu, Jan 3, 2019 at 12:53 AM Puneeth PS <[email protected]> wrote:
> >
> > > Hi Ivan,
> > >
> > > I have made the changes requested and I've some questions regarding the
> > > spec which I've asked on the github thread, can you please clarify
> these?
> > >
> > > On Wed 2 Jan, 2019, 6:09 PM Ivan Junckes Filho <[email protected]
> > > wrote:
> > >
> > > > Puneeth, I did some comments here
> > > > https://github.com/apache/tomee/pull/340#pullrequestreview-188661807
> ,
> > > > please take a look.
> > > >
> > > > On Wed, Jan 2, 2019 at 9:51 AM Ivan Junckes Filho <
> > [email protected]
> > > >
> > > > wrote:
> > > >
> > > > > Hi Puneeth, I will review it for you.
> > > > >
> > > > > On Wed, Jan 2, 2019 at 8:39 AM Puneeth PS <[email protected]>
> > > wrote:
> > > > >
> > > > >> Hi,
> > > > >>
> > > > >> I have created a PR ( https://github.com/apache/tomee/pull/340 )
> > for
> > > > >> TOMEE-2289. Can someone take a look and help me improve it?
> > > > >>
> > > > >
> > > >
> > >
> >
>

Reply via email to