Hey all, I will happily donate my time to do another milestone next week if we can focus on doing the right thing now.
I see three forms of technical debt in this exchange: - No tests - The only real description is a long email thread - An undocumented property no one understands Side note to everyone on TCKs and system properties: we have to pass TCKs with the default settings we ship. If we have to disable/enable features to pass a TCK, we haven't passed the TCK. I've read the PR, JIRA and thread and there isn't enough information there for anyone to help create a test case. The input is clear, but the expected output is not. Something as simple as "I want this [code snippet], but I'm getting this [code snippet]" would go a long way. There are a bunch of excited people looking for something to hack on that might be able to help with finishing the PR. I'm sure someone would be willing to step up and help get this finished and merged. -- David Blevins http://twitter.com/dblevins http://www.tomitribe.com > On May 14, 2019, at 11:38 PM, Ivan Junckes Filho <ivanjunc...@gmail.com> > wrote: > > Removing that flag doesn't fix the problem unfortunately. I saw your > comment Jon, but the issue is not with Geronimo as far as I understand. > TomEE uses InternalApplication instead of using the custom Application > config and because of that geronimo doesn't pick it up in the geronimo > extension. > > I added the apache header Jean-Louis. I think Otavio asked for help to > write a test, but nobody replied. > > Basically openapiextension ignores @OpenAPIDefinition and the result is > that none of those values are added to the final openapi document. > > On Tue, May 14, 2019 at 10:26 AM Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > >> Agreed. >> >> Le mar. 14 mai 2019 à 15:24, Jonathan Gallimore < >> jonathan.gallim...@gmail.com> a écrit : >> >>> I added a note on the PR. I did find the discussion on the mailing list: >>> >>> >> http://tomee-openejb.979440.n4.nabble.com/OpenAPIDefinition-not-working-td4687918.html >>> . >>> >>> It sounded like a flag is needed to pass the TCK currently - preference >>> would be that there is a test for this issue (which could just be an >>> Arquillian test which reads from /openapi, right?), but at the very >> least, >>> some indication that this is covered by the TCK and the removal of >>> the openejb.cxf-rs.cache-application=false setting in the existing TCK >>> module. >>> >>> Jon >>> >>> >>> On Tue, May 14, 2019 at 1:29 PM Ivan Junckes Filho < >> ivanjunc...@gmail.com> >>> wrote: >>> >>>> Hey guys, this PR from Otavio fixes a very bad issue with OpenAPI in >>> TomEE >>>> regarding the use of InternalApplication. >>>> >>>> https://issues.apache.org/jira/browse/TOMEE-2502 >>>> >>>> I reviewed the PR and it really fixes the issue. >>>> >>>> Can someone please merge this? This is pending for awhile and I would >>>> appreciate a lot to have this fix in. >>>> >>>> https://github.com/apache/tomee/pull/454 >>>> >>> >>
