I filed this ticket this morning:
https://issues.apache.org/jira/browse/TOMEE-2792

You can reproduce this by extracting a vanilla TomEE 8.0.1, and deleting
tomee.xml from the conf/ folder. What you'll see is that TomEE starts
looking for conf/openejb.xml and creates it from a default if it isn't
found.

There's a bit of (possibly interesting) history here: the TomEE project
grew out of a project called OpenEJB, which provided an EJB container that
was embeddable, and also a standalone EJB server. We also shipped
openejb.war which could be deployed in a vanilla Tomcat to create what we
now call TomEE. Things haven't changed that much in this regard - this is
still how we actually build the TomEE binaries.

The standalone EJB server uses conf/openejb.xml for its config. TomEE uses
conf/tomee.xml, but they are basically the same.

The logic here is:

TomEE searches for the config file here:
https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java#L427
and delegates to ConfigUtils.searchForConfiguration().
The openejb.configuration property is set here:
https://github.com/apache/tomee/blob/master/tomee/tomee-catalina/src/main/java/org/apache/tomee/catalina/TomcatLoader.java#L171.
Doing something like: SystemInstance.get().getProperty("openejb.loader",
"foo").startsWith("tomcat"); should enable you to determine if we're
running as TomEE or the (still working and supported) EJB standalone server.

Ideally, if tomee.xml is missing, we should explicitly log that, and
continue. We shouldn't create a default file.

What do you think? If that doesn't sound like fun, do feel free to have a
look at some of the other tickets, and feel free to ask questions.
https://issues.apache.org/jira/projects/TOMEE/issues

Cheers

Jon


On Fri, Mar 27, 2020 at 4:14 PM Mihai A. <[email protected]> wrote:

> Hi Jonathan,
>
> Thank you. No, I don't have anything specific in mind.
> I'm happy to look at a few JIRA tickets.
>
> Best regards,
> Mihai
>
> On Fri, 27 Mar 2020 at 18:11, Jonathan Gallimore <
> [email protected]> wrote:
>
> > Hi Mihai
> >
> > Thanks for introducing yourself, and welcome! Is there anything you
> > specifically wanted to work on in TomEE? If not, I'm happy to suggest a
> > couple of JIRAs to take a look at.
> >
> > Cheers
> >
> > Jon
> >
> > On Fri, Mar 27, 2020 at 2:25 PM Mihai A. <[email protected]> wrote:
> >
> > > Hi everyone!
> > >
> > > I am interested in contributing to TomEE. I am an experienced Java
> > > Developer with years of experience in working remotely on Github.
> > >
> > > I have a lot of projects of my own (Java 8 mostly) and I also try to
> > > contribute to other projects. The best thing I can do is integration
> > work,
> > > developing Java clients for external services and so on. Please see
> > > amihaiemi/docker-java-api and jcabi/jcabi-github as example of Java API
> > > Wrappers.
> > >
> > > I am also blogging about experimental (let's call it like that) OOP.
> > > Besides OOP, I also cover topics such as unit testing, integration
> > testing,
> > > ci-cd automations etc.
> > >
> > > Best regards,
> > > Mihai
> > >
> > > --
> > > amihaiemil.com
> > > https://www.github.com/amihaiemil
> > >
> >
>
>
> --
> amihaiemil.com
> https://www.github.com/amihaiemil
>

Reply via email to