Thank you for the review, David! Jon
On Sat, 20 Jun 2020, 15:36 David Jencks, <david.a.jen...@gmail.com> wrote: > Thanks! > > With these additions, +1 > > David Jencks > > > On Jun 19, 2020, at 11:13 PM, Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > > I missed copying those from the staged Maven repo - here they are (the > > .ascs, sha256s and sha512s are there too): > > > > TomEE: > > > https://dist.apache.org/repos/dist/dev/tomee/staging-1172/tomee-8.0.3/tomee-project-8.0.3-source-release.zip > > Patch Plugin: > > > https://dist.apache.org/repos/dist/dev/tomee/staging-1172/tomee-8.0.3/tomee-patch-parent-0.1-source-release.zip > > TomEE Jakarta Conversion: > > > https://dist.apache.org/repos/dist/dev/tomee/staging-1172/tomee-8.0.3/apache-tomee-9.0.0-M1-source-release.zip > > > > Jon > > > > On Sat, Jun 20, 2020 at 5:29 AM David Jencks <david.a.jen...@gmail.com> > > wrote: > > > >> Sorry to be sticky, but an apache release is source code, packaged > >> sufficiently to be able to build the product. A git tag isn’t > sufficient. > >> Everything else, such as jars, are convenience artifacts. AFAICT > there’s > >> nothing to vote on here :-( > >> > >> It’s been many years but IIRC there’s a way to get maven to package up > the > >> clean source project just like a git checkout. That’s what I was > expecting > >> so I could look over the source and legal files. > >> > >> David Jencks > >> > >>> On Jun 19, 2020, at 9:20 PM, David Blevins <david.blev...@gmail.com> > >> wrote: > >>> > >>> Not 100% confident on this, but I think it's these tags built in this > >> order: > >>> > >>> - > >> > https://github.com/apache/tomee-patch-plugin/tree/tomee-patch-parent-0.1 > >>> - https://github.com/apache/tomee/tree/tomee-project-8.0.3 > >>> - https://github.com/apache/tomee-jakarta/tree/apache-tomee-9.0.0-M1 > >>> > >>> Hopefully after this release we can eliminate the need for the > >> tomee-jakarta repo and merge that into tomee/master. As well, ideally > we > >> can hopefully use the v0.1 of the TomEE Patch Plugin and release that > >> separately as needed. > >>> > >>> > >>> -David > >>> > >>> > >>>> On Jun 19, 2020, at 8:38 PM, David Jencks <david.a.jen...@gmail.com> > >> wrote: > >>>> > >>>> I can’t find the source archive that I can build locally to get all > >> those juicy binary artifacts in > >> https://dist.apache.org/repos/dist/dev/tomee/staging-1172/tomee-8.0.3/ > < > >> https://dist.apache.org/repos/dist/dev/tomee/staging-1172/tomee-8.0.3/> > >>>> > >>>> ??? > >>>> > >>>> thanks > >>>> david jencks > >>>> > >>>>> On Jun 19, 2020, at 6:01 AM, Jonathan Gallimore < > >> jonathan.gallim...@gmail.com> wrote: > >>>>> > >>>>> Hi All, > >>>>> > >>>>> I am delighted to present a vote for Apache TomEE 9.0.0-M1 and Apache > >> TomEE > >>>>> 8.0.3. > >>>>> > >>>>> There's some background on this release here: > >>>>> > >> > https://lists.apache.org/thread.html/r1d89e3c1cd9dba9695e059c96efc8af0d68f18e40c4d4c688801db8d%40%3Cdev.tomee.apache.org%3E > >>>>> > >>>>> The key points here are: > >>>>> > >>>>> * TomEE 8.0.3 is essentially identical to TomEE 8.0.2, bar some > >> changes to > >>>>> examples. Release notes are below. > >>>>> > >>>>> * TomEE 9.0.0-M1 is a transformed version of TomEE 8.0.3, to shift > >> TomEE > >>>>> and all its dependencies from the javax to jakarta namespace. > >>>>> > >>>>> * If you're targeting Jakarta EE 8, use TomEE 8.0.3. If you would > like > >> to > >>>>> try out Jakarta EE 9, with the new namespace, try TomEE 9.0.0-M1. If > >> you > >>>>> build the examples, for most of them you should get a `javax` version > >> and a > >>>>> `jakarta` version. Moviefun is a good app to use to play around. > >>>>> > >>>>> * TomEE 8.0.3 is production-ready. TomEE 9.0.0-M1 is a milestone. > We'd > >> love > >>>>> you to try it, kick the tyres and provide feedback. There will likely > >> be a > >>>>> few milestone releases before we get to a production-ready 9.0.0. > >>>>> > >>>>> * We expect things to not work with the 9.0.0-M1 version. Feedback is > >>>>> gratefully received, but will be addressed with subsequent releases. > >>>>> Genuine show-stopper issues, such as legal issues, should be voted > -1, > >> but > >>>>> bugs or functionality in the 9.0.0-M1 should not prevent this release > >> going > >>>>> ahead. If you have questions around this, please let us know. > >>>>> > >>>>> * Both versions are built from the same codebase, hence the single > >> vote. > >>>>> > >>>>> * This vote includes the release of a patch plugin: > >>>>> https://github.com/apache/tomee-patch-plugin, and one separate > single > >>>>> module to do the translation work for the jakarta version: > >>>>> https://github.com/apache/tomee-jakarta. I'm expecting the > >>>>> tomee-jakara repo to be removed and the module bought back under the > >> tomee > >>>>> tree when we can work out the build issues there. > >>>>> > >>>>> Maven Repo: > >>>>> > >> https://repository.apache.org/content/repositories/orgapachetomee-1172/ > >>>>> > >>>>> Binaries & Source: > >>>>> > https://dist.apache.org/repos/dist/dev/tomee/staging-1172/tomee-8.0.3/ > >>>>> > >>>>> Tags: > >>>>> > >>>>> > >> > https://gitbox.apache.org/repos/asf?p=tomee.git;a=tag;h=refs/tags/tomee-project-8.0.3 > >>>>> > >> > https://gitbox.apache.org/repos/asf?p=tomee-patch-plugin.git;a=tag;h=refs/tags/tomee-patch-parent-0.1 > >>>>> > >> > https://gitbox.apache.org/repos/asf?p=tomee-jakarta.git;a=tag;h=refs/tags/apache-tomee-9.0.0-M1 > >>>>> > >>>>> Release notes: > >>>>> > >>>>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12348219 > >>>>> > >>>>> Please VOTE: > >>>>> > >>>>> [+1] Yes, release it > >>>>> [+0] Not fussed > >>>>> [-1] Don't release, there's a showstopper (please specify what the > >>>>> showstopper is) > >>>>> > >>>>> Vote will be open for 72 hours. > >>>>> > >>>>> Here is my +1. > >>>>> > >>>>> Thanks > >>>>> > >>>>> Jon > >>>> > >>> > >> > >> > >
