> On Sep 4, 2020, at 11:10 AM, Jonathan Gallimore 
> <jonathan.gallim...@gmail.com> wrote:
> 
> This is the specific part of the code where the Geronimo OpenAPI service is
> filtered out:
> https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/cdi/OptimizedLoaderService.java#L164-L165
> .
> 
> I hope that helps.

It definitely did.  I found a way to get it to pass.  I don't know if there are 
other consequences.

It's effectively these three lines of code (first link) added in this commit 
(second link)

 - 
https://github.com/apache/tomee/blob/142f035e454b43192c51db7a66b9395982502d47/container/openejb-core/src/main/java/org/apache/openejb/cdi/OptimizedLoaderService.java#L159-L161
 - 
https://github.com/apache/tomee/commit/1ebb0ee181622cd101df64a82f8af3bcb27211bf#diff-da64938534b0686bfc3d264149fac1f2R106-R108

There's no test or javadoc and the commit message says its for jcache.

I'm going to try to get the build green again and then yank.


-David

> 
> Jon
> 
> On Fri, 4 Sep 2020, 18:40 David Blevins, <dblev...@tomitribe.com> wrote:
> 
>> If the commit did have some means to handle the duplicate classes, it's
>> the exact insight I'm looking for even if it isn't working.
>> 
>> Even knowing that there was something that was supposed to handle it is
>> useful as that means I just need to find what was supposed to work and then
>> figure out why it doesn't.
>> 
>> If you didn't have to do anything at all and things just magically worked,
>> then the starting point is less clear.
>> 
>> 
>> -David
>> 
>>> On Sep 4, 2020, at 10:12 AM, Jonathan Gallimore <
>> jonathan.gallim...@gmail.com> wrote:
>>> 
>>> It definitely sounds like fun :)
>>> 
>>> On Fri, 4 Sep 2020, 18:10 David Blevins, <dblev...@tomitribe.com> wrote:
>>> 
>>>> 
>>>>> On Sep 4, 2020, at 8:48 AM, Jonathan Gallimore <
>>>> jonathan.gallim...@gmail.com> wrote:
>>>>> 
>>>>> Off the top of my head - I don't know. I'll run your test and dig
>> through
>>>>> over the weekend.
>>>> 
>>>> No worries, I'll continue digging.  I thought there might be a "I had
>> that
>>>> issue and did the thing with the thing, you probably need to adjust it."
>>>> 
>>>> If nothing jumps out, no need to dig unless that sounds fun :)
>>>> 
>>>> 
>>>> -David
>>>> 
>>>> 
>>>>> 
>>>>> On Fri, Sep 4, 2020 at 4:16 AM David Blevins <david.blev...@gmail.com>
>>>>> wrote:
>>>>> 
>>>>>> Ok, so here's the error that keeps the TomEE MicroProfile, Plus and
>>>> Plume
>>>>>> examples from booting.
>>>>>> 
>>>>>> It appears we get an AmbiguousResolutionException from OpenWebBeans
>>>>>> because we have these two beans getting picked up and they conflict
>> with
>>>>>> each other:
>>>>>> 
>>>>>> 
>>>>>> - TomEEOpenAPIExtension, WebBeansType:EXTENSION, Name:null, API
>>>>>>   Types:[java.lang.Object,javax.enterprise.inject.spi.Extension,
>>>>>>          org.apache.tomee.microprofile.config.TomEEOpenAPIExtension,
>>>>>> 
>>>>>> 
>> org.apache.geronimo.microprofile.openapi.cdi.GeronimoOpenAPIExtension],
>>>>>> 
>>>>>> 
>> Qualifiers:[javax.enterprise.inject.Default,javax.enterprise.inject.Any]
>>>>>>   from
>>>>>> 
>>>>>> 
>>>> 
>> jar:file:/Users/dblevins/.m2/repository/org/apache/tomee/mp-common/8.0.5-SNAPSHOT/mp-common-8.0.5-SNAPSHOT.jar
>>>>>> 
>>>> !/org/apache/tomee/microprofile/config/TomEEOpenAPIExtension.class
>>>>>> 
>>>>>> 
>>>>>> - GeronimoOpenAPIExtension, WebBeansType:EXTENSION, Name:null, API
>>>>>>   Types:[java.lang.Object,javax.enterprise.inject.spi.Extension,
>>>>>> 
>>>>>> 
>> org.apache.geronimo.microprofile.openapi.cdi.GeronimoOpenAPIExtension],
>>>>>> 
>>>>>> 
>> Qualifiers:[javax.enterprise.inject.Default,javax.enterprise.inject.Any]
>>>>>>   from
>>>>>> 
>>>>>> 
>>>> 
>> jar:file:/Users/dblevins/.m2/repository/org/apache/geronimo/geronimo-openapi-impl/1.0.12/geronimo-openapi-impl-1.0.12.jar
>>>>>> 
>>>>>> 
>>>> 
>> !/org/apache/geronimo/microprofile/openapi/cdi/GeronimoOpenAPIExtension.class
>>>>>> 
>>>>>> 
>>>>>> It looks like TomEEOpenAPIExtension was added in this commit:
>>>>>> 
>>>>>> -
>>>>>> 
>>>> 
>> https://github.com/apache/tomee/commit/10265708029ab2d0576f03aa1d5bb0a8a20bfffd
>>>>>> 
>>>>>> Jon, looks like you added TomEEOpenAPIExtension.  Is there any trick
>> you
>>>>>> needed to do to avoid the above conflict in our standalone servers?
>>>>>> 
>>>>>> If anyone has any insight, it's very appreciated.  This can be
>>>> reproduced
>>>>>> with this example:
>>>>>> 
>>>>>> -
>>>>>> 
>>>> 
>> https://github.com/apache/tomee/tree/master/examples/serverless-tomee-microprofile
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> -David
>>>>>> 
>>>>>> 
>>>> 
>>>> 
>> 
>> 

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to