> On Sep 4, 2020, at 1:34 PM, David Blevins <david.blev...@gmail.com> wrote: > >> On Sep 4, 2020, at 11:10 AM, Jonathan Gallimore >> <jonathan.gallim...@gmail.com> wrote: >> >> This is the specific part of the code where the Geronimo OpenAPI service is >> filtered out: >> https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/cdi/OptimizedLoaderService.java#L164-L165 >> . >> >> I hope that helps. > > It definitely did. I found a way to get it to pass. I don't know if there > are other consequences. > > It's effectively these three lines of code (first link) added in this commit > (second link) > > - > https://github.com/apache/tomee/blob/142f035e454b43192c51db7a66b9395982502d47/container/openejb-core/src/main/java/org/apache/openejb/cdi/OptimizedLoaderService.java#L159-L161 > - > https://github.com/apache/tomee/commit/1ebb0ee181622cd101df64a82f8af3bcb27211bf#diff-da64938534b0686bfc3d264149fac1f2R106-R108 > > There's no test or javadoc and the commit message says its for jcache. > > I'm going to try to get the build green again and then yank. >
Ok, yanked those lines and added in the MicroProfile, Plus and Plume examples. Build looks happy! - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1426 These look good to go. From here I think it's just a matter of starting to use this more and more and see what if any issues arise. Might be nice to have an Arquillian version and potentially deprecate/remove the old incomplete embedded adapter. -David
smime.p7s
Description: S/MIME cryptographic signature
