Merged! What an amazing end to the Jakarta EE 9 release day :)
-- David Blevins http://twitter.com/dblevins http://www.tomitribe.com > On Dec 8, 2020, at 5:18 PM, Thiago Henrique Hupner <thi...@gmail.com> wrote: > > Sure! I'll do right away > > Em ter., 8 de dez. de 2020 às 22:17, David Blevins <david.blev...@gmail.com> > escreveu: > >>> On Dec 8, 2020, at 5:07 PM, David Blevins <david.blev...@gmail.com> >> wrote: >>> >>> PR merged :) >>> >>> - https://github.com/apache/tomee-tck/pull/13 >>> >>> Thank you much, Thiago! So amazing to see this kind of activity. You >> rock, Thiago! >> >> Oh, we have another branch for the Jakarta EE 9 TCK here: >> >> - https://github.com/apache/tomee-tck/tree/jakartaee9-tck >> >> If you're up for pulling that commit over and submitting another PR, >> awesome! Otherwise I'll do a cherry pick tomorrow. >> >> -David >> >>> >>>> On Dec 8, 2020, at 4:36 PM, David Blevins <david.blev...@gmail.com> >> wrote: >>>> >>>> Wow, I did not expect to get an email like this so fast :) It's >> awesome. >>>> >>>> We build the ts.jte file dynamically in Groovy here: >>>> >>>> - >> https://github.com/apache/tomee-tck/blob/master/src/test/script/openejb/tck/commands/SetupCommand.groovy#L37 >>>> >>>> That code is basically there to take this input file: >>>> >>>> - >> https://github.com/apache/tomee-tck/blob/master/src/test/resources/testsuite.properties >>>> >>>> ...and fill out any variables that would otherwise have to be hardcoded >> (versions in jar names, etc.). Then it overrides the ts.jte file that >> comes with the TCK and that's the one that gets used. >>>> >>>> That said, there are still some hardcoded jar names, but... more >> opportunities for contribution :) We build other paths here: >>>> >>>> - >> https://github.com/apache/tomee-tck/blob/master/src/test/script/openejb/tck/commands/CommandSupport.groovy#L155 >>>> >>>> So the short answer is we can either do the work in the >> testsuite.properties file or build the right path in initPaths and make the >> generateTsJte function smart enough put it into the ts.jte. Or some >> combination of both. >>>> >>>> Side note: if you start digging into these groovy files and have an >> urge to refactor them go ahead :) We actually grabbed this setup from >> Geronimo and it's only been minorly changed over the years. Any kind of >> love is welcome. >>>> >>>> >>>> -- >>>> David Blevins >>>> http://twitter.com/dblevins >>>> http://www.tomitribe.com >>>> >>>>> On Dec 8, 2020, at 3:48 PM, Thiago Henrique Hupner <thi...@gmail.com> >> wrote: >>>>> >>>>> Hi all! >>>>> >>>>> I did some looking and most of the server push tests are failing >> because >>>>> the TCK client is failing to startup correctly. >>>>> >>>>> https://tck.work/tomee/api/testlog/276/1607111275890 >>>>> >>>>> This is happening because in the command line to run the client is not >>>>> specified the flow.jar library that is included in the >>>>> jakartaee-tck/endorsedlib/flow.jar. >>>>> >>>>> This jar has to be included in the java.endorsed.dirs property (but >> only >>>>> for JDK 8) or with -Xbootclasspath/a flag(to run with JDK 8 or higher). >>>>> >>>>> I guess the change must be in the ts.jte, but I couldn't figure out >> where >>>>> this file is in the current setup. >>>>> >>>>> Thanks >>>> >>> >> >>
smime.p7s
Description: S/MIME cryptographic signature
