After discussing it on Slack, I proposed to disable the 2 tests. It does not sound justified to hold a release that so many users are waiting for, for a small feature that probably no one is currently using. We can implement it back if someone complains and we can't workaround it.
org.apache.openejb.server.cxf.rs.DisableTomEEJohnzonTest.client org.apache.openejb.server.cxf.rs.AppPropertiesPropagationTest.checkStarIsNotAnIssue We should get back into a green build again. And therefore ready for a release soon. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Jun 9, 2021 at 7:53 AM Jean-Louis Monteiro <[email protected]> wrote: > We are 2 failures away from green now. > One of them is a system property to disable Johnzon on the client side > which is not supported anymore. > The other one, I need to look at it.... > > I'm trying to get some TCK results > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Mon, Jun 7, 2021 at 4:08 PM Zowalla, Richard < > [email protected]> wrote: > >> +1 >> >> Am Montag, den 07.06.2021, 15:30 +0200 schrieb Jean-Louis Monteiro: >> > Small update. >> > I'm going to push to the PR and merge the changes I have for now. >> > >> > Short story is I had to revert some changes for the @AroundConstruct >> > because it's breaking too many things. We need to see if we can find >> > another way to pass this test. >> > I have imported all the CXF patching and created a shaded version. >> > Did a bit of cleanup in dependencies. >> > Fixed WebSocket issues. >> > >> > We might still have some issues pending but I'd like to see the TCK >> > results >> > at this point. >> > >> > Any issue? >> > >> > -- >> > Jean-Louis Monteiro >> > http://twitter.com/jlouismonteiro >> > http://www.tomitribe.com >> > >> > >> > On Fri, Jun 4, 2021 at 1:20 PM Jean-Louis Monteiro < >> > [email protected]> >> > wrote: >> > >> > > I'll be pushing shortly some more changes. >> > > We'll see. But websocket issues should be fixed now. >> > > >> > > >> > > Le mer. 2 juin 2021 à 17:00, Zowalla, Richard < >> > > [email protected]> a écrit : >> > > >> > > > Thanks. Images are blocked on the list, but from your >> > > > description, it >> > > > seems, that you mean >> > > > >> > > > org.apache.openejb.server.cxf.rs.DisableTomEEJohnzonTest.client >> > > > org.apache.openejb.server.cxf.rs.DisableTomEEJohnzonTest.server >> > > > org.superbiz.composed.rest.GreetingServiceTest.checkProviderIsUs >> > > > ed >> > > > >> > > > I think, that >> > > > >> > > > >> > > > org.apache.openejb.server.cxf.rs.CheckedExceptionMapperTest.test >> > > > ThrowException >> > > > >> > > > might be solvable by adding an additional null check for >> > > > application. >> > > > There are many ways to wrap a null application. I assume, that it >> > > > is >> > > > similar to [1]. I have created a PR for it targeting your fix >> > > > branch >> > > > [2] as the test passes locally. >> > > > >> > > > Gruss >> > > > Richard >> > > > >> > > > >> > > > [1] >> > > > >> > > > >> https://github.com/apache/tomee/commit/8dd89daec484a84b2dd8e0f97a29f87a4d4fd3a4 >> > > > [2] https://github.com/jeanouii/tomee/pull/4 >> > > > >> > > > Am Mittwoch, den 02.06.2021, 15:58 +0200 schrieb Jean-Louis >> > > > Monteiro: >> > > > > >> > > > > >> > > > > The 2 first and the last one. >> > > > > Trying to understand the async-servlet related issues. For the >> > > > > 2 last >> > > > > cxf-rs, I'd need David's input >> > > > > >> > > > > >> > > > > -- >> > > > > Jean-Louis Monteiro >> > > > > http://twitter.com/jlouismonteiro >> > > > > http://www.tomitribe.com >> > > > > >> > > > > >> > > > > On Wed, Jun 2, 2021 at 9:56 AM Zowalla, Richard < >> > > > > [email protected]> wrote: >> > > > > > Hi, >> > > > > > >> > > > > > thanks for the work! Hopefully, we are soon green again and >> > > > > > can go >> > > > > > for >> > > > > > 8.0.8 >> > > > > > >> > > > > > Can you provide more information, which tests might not be >> > > > > > relevant? >> > > > > > >> > > > > > Looks like, that it isn't possible to disable the johnzon >> > > > > > provider >> > > > > > via >> > > > > > "org.apache.openejb.server.cxf.rs.johnzon.TomEEJohnzonProvide >> > > > > > r.acti >> > > > > > vate >> > > > > > d" anymore. This is something, which was mentioned in [1] by >> > > > > > Romain. >> > > > > > >> > > > > > Gruss >> > > > > > Richard >> > > > > > >> > > > > > [1] >> > > > > > https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-3742 >> > > > > > >> > > > > > >> > > > > > >> > > > > > Am Montag, den 31.05.2021, 14:04 +0200 schrieb Jean-Louis >> > > > > > Monteiro: >> > > > > > > Hello, >> > > > > > > >> > > > > > > Been trying to work on the build. >> > > > > > > Created the following PR and kept improving it >> > > > > > > >> > > > > > > https://github.com/apache/tomee/pull/800 >> > > > > > > >> > > > > > > Such as we are 9 failures only away from green build. Some >> > > > > > failures >> > > > > > > might >> > > > > > > not be relevant and require you to remove the tests or >> > > > > > > change >> > > > > > them. >> > > > > > > But >> > > > > > > I'll need some help from David who worked quite heavily on >> > > > > > > CXF so >> > > > > > I >> > > > > > > don't >> > > > > > > have to pay that same cost. >> > > > > > > >> > > > > > > >> > > > >> https://ci-builds.apache.org/job/Tomee/job/pull-request/lastBuild/testReport/ >> > > > > > > I'm trying to address the websocket failures but any help >> > > > > > > is >> > > > > > welcome >> > > > > > > as >> > > > > > > usual >> > > > > > > >> > > > > > > -- >> > > > > > > Jean-Louis Monteiro >> > > > > > > http://twitter.com/jlouismonteiro >> > > > > > > http://www.tomitribe.com >> > > > >> >
