Hi all, we made some progress in stabilizing the full build. The examples in the full build are back to green.
However, we still have some regressions to fix as shown by the test results in [1]. Currently, we have 21 failing tests in the following modules: - TomEE :: Arquillian Adaptors Parent :: Tests :: JAXWS - TomEE :: Arquillian Adaptors Parent :: Tests :: Web Profile - TomEE :: TCK :: CDI TomEE - TomEE :: TCK :: MicroProfile Open Tracing TCK The OpenTracing TCK probably suffers from the same issues as the MP TCK tests. JL started a related thread [2 but it requires some more clarification as we would need to add an additional property... [3] Maybe someone has the time to take a look or has some additional thougts on [2] or on any failing other test? I guess, it would be neat to fix it before the summer break. Gruss Richard [1] https://ci-builds.apache.org/job/Tomee/job/master-build-full/236/ [2] http://mail-archives.apache.org/mod_mbox/tomee-dev/202106.mbox/%3CCAPkio3GyO91ZnpKNcbFM4goEzz3JKtdtrQ-dWdRewLpV2n6YKg%40mail.gmail.com%3E [3] https://github.com/apache/tomee/commit/99c0b706b12514ae3101ca5b956d5b87a3f037c9 Am Donnerstag, den 17.06.2021, 09:12 +0000 schrieb Zowalla, Richard: > Hi all, > > we managed to get the quick build to be "green" again. > > The full build had memory issues in tomee-cdi, didn't complete and > timed out after 8 hours. I increased the heap space for the related > module - the build is running now and shows some test failures [1]. > > They are mostly in the following modules: > > - TomEE :: Arquillian Adaptors Parent :: Tests :: JAXWS > - TomEE :: TCK :: CDI TomEE > - TomEE :: TCK :: MicroProfile Open API TCK > - TomEE :: TCK :: MicroProfile Open Tracing TCK > > Might be related to the JAX-RS / JAX-WS changes. Don't know. > > Gruß > Richard > > > [1] https://ci-builds.apache.org/job/Tomee/job/master-build-full/ > > Am Freitag, den 11.06.2021, 16:03 +0200 schrieb Jean-Louis Monteiro: > > Thanks Richard for helping out. > > Let's wait for the full build but indeed it looks in a better > > shape. > > I'd > > like to get some good numbers from EE8 TCK with TomEE 8.0.8 so we > > have > > confidence to release. Does not matter too much if we have a few > > TCK > > failures for most people. It only matters if we want to also get > > TomEE a > > EE8 compatible implementation as we have done for TomEE 9 > > -- > > Jean-Louis Monteiro > > http://twitter.com/jlouismonteiro > > http://www.tomitribe.com > > > > > > On Fri, Jun 11, 2021 at 12:48 PM Zowalla, Richard < > > [email protected]> wrote: > > > > > I pushed a workaround, so the failing test shouldn't be a problem > > > anymore. > > > > > > _All_ tests are passing now (at least on the quick build) on the > > > CI > > > env: > > > https://ci-builds.apache.org/job/Tomee/job/master-build-quick/133/ > > > > > > However the build is still broken. Might also be Jenkins as it > > > passes > > > locally... > > > > > > Am Freitag, den 11.06.2021, 07:13 +0000 schrieb Zowalla, Richard: > > > > It looks like, that we have only one failing test left, which > > > > is > > > > unrelated to the actual TCK work: > > > > > > > > - ReloadableEntityManagerFactoryTest > > > > > > > > fails after the upgrade to OpenJPA 3.2.0 (TOMEE-3753) due to > > > > https://issues.apache.org/jira/browse/OPENJPA-2844 > > > > > > > > It is IMHO no real blocker as we can revert the upgrade (or > > > > ignore > > > > the > > > > test for now). Any thoughts? > > > > > > > > Gruss > > > > Richard > > > > > > > > Am Donnerstag, den 10.06.2021, 18:28 +0200 schrieb Jean-Louis > > > > Monteiro: > > > > > After discussing it on Slack, I proposed to disable the 2 > > > > > tests. It > > > > > does > > > > > not sound justified to hold a release that so many users are > > > > > waiting > > > > > for, > > > > > for a small feature that probably no one is currently using. > > > > > We can implement it back if someone complains and we can't > > > > > workaround > > > > > it. > > > > > > > > > > org.apache.openejb.server.cxf.rs.DisableTomEEJohnzonTest.clie > > > > > nt > > > > > org.apache.openejb.server.cxf.rs.AppPropertiesPropagationTest > > > > > .c > > > > > heck > > > > > St > > > > > arIsNotAnIssue > > > > > > > > > > We should get back into a green build again. And therefore > > > > > ready > > > > > for > > > > > a > > > > > release soon. > > > > > > > > > > > > > > > > > > > > -- > > > > > Jean-Louis Monteiro > > > > > http://twitter.com/jlouismonteiro > > > > > http://www.tomitribe.com > > > > > > > > > > > > > > > On Wed, Jun 9, 2021 at 7:53 AM Jean-Louis Monteiro < > > > > > [email protected]> > > > > > wrote: > > > > > > > > > > > We are 2 failures away from green now. > > > > > > One of them is a system property to disable Johnzon on the > > > > > > client > > > > > > side > > > > > > which is not supported anymore. > > > > > > The other one, I need to look at it.... > > > > > > > > > > > > I'm trying to get some TCK results > > > > > > > > > > > > -- > > > > > > Jean-Louis Monteiro > > > > > > http://twitter.com/jlouismonteiro > > > > > > http://www.tomitribe.com > > > > > > > > > > > > > > > > > > On Mon, Jun 7, 2021 at 4:08 PM Zowalla, Richard < > > > > > > [email protected]> wrote: > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > Am Montag, den 07.06.2021, 15:30 +0200 schrieb Jean-Louis > > > > > > > Monteiro: > > > > > > > > Small update. > > > > > > > > I'm going to push to the PR and merge the changes I > > > > > > > > have > > > > > > > > for > > > > > > > > now. > > > > > > > > > > > > > > > > Short story is I had to revert some changes for the > > > > > > > > @AroundConstruct > > > > > > > > because it's breaking too many things. We need to see > > > > > > > > if > > > > > > > > we > > > > > > > > can > > > > > > > > find > > > > > > > > another way to pass this test. > > > > > > > > I have imported all the CXF patching and created a > > > > > > > > shaded > > > > > > > > version. > > > > > > > > Did a bit of cleanup in dependencies. > > > > > > > > Fixed WebSocket issues. > > > > > > > > > > > > > > > > We might still have some issues pending but I'd like to > > > > > > > > see > > > > > > > > the > > > > > > > > TCK > > > > > > > > results > > > > > > > > at this point. > > > > > > > > > > > > > > > > Any issue? > > > > > > > > > > > > > > > > -- > > > > > > > > Jean-Louis Monteiro > > > > > > > > http://twitter.com/jlouismonteiro > > > > > > > > http://www.tomitribe.com > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Jun 4, 2021 at 1:20 PM Jean-Louis Monteiro < > > > > > > > > [email protected]> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > I'll be pushing shortly some more changes. > > > > > > > > > We'll see. But websocket issues should be fixed now. > > > > > > > > > > > > > > > > > > > > > > > > > > > Le mer. 2 juin 2021 à 17:00, Zowalla, Richard < > > > > > > > > > [email protected]> a écrit : > > > > > > > > > > > > > > > > > > > Thanks. Images are blocked on the list, but from > > > > > > > > > > your > > > > > > > > > > description, it > > > > > > > > > > seems, that you mean > > > > > > > > > > > > > > > > > > > > org.apache.openejb.server.cxf.rs.DisableTomEEJohnz > > > > > > > > > > on > > > > > > > > > > Test > > > > > > > > > > .c > > > > > > > > > > lient > > > > > > > > > > org.apache.openejb.server.cxf.rs.DisableTomEEJohnz > > > > > > > > > > on > > > > > > > > > > Test > > > > > > > > > > .s > > > > > > > > > > erver > > > > > > > > > > org.superbiz.composed.rest.GreetingServiceTest.che > > > > > > > > > > ck > > > > > > > > > > Prov > > > > > > > > > > id > > > > > > > > > > erIsUs > > > > > > > > > > ed > > > > > > > > > > > > > > > > > > > > I think, that > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > org.apache.openejb.server.cxf.rs.CheckedExceptionM > > > > > > > > > > ap > > > > > > > > > > perT > > > > > > > > > > es > > > > > > > > > > t.test > > > > > > > > > > ThrowException > > > > > > > > > > > > > > > > > > > > might be solvable by adding an additional null > > > > > > > > > > check > > > > > > > > > > for > > > > > > > > > > application. > > > > > > > > > > There are many ways to wrap a null application. I > > > > > > > > > > assume, > > > > > > > > > > that it > > > > > > > > > > is > > > > > > > > > > similar to [1]. I have created a PR for it > > > > > > > > > > targeting > > > > > > > > > > your > > > > > > > > > > fix > > > > > > > > > > branch > > > > > > > > > > [2] as the test passes locally. > > > > > > > > > > > > > > > > > > > > Gruss > > > > > > > > > > Richard > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/tomee/commit/8dd89daec484a84b2dd8e0f97a29f87a4d4fd3a4 > > > > > > > > > > [2] https://github.com/jeanouii/tomee/pull/4 > > > > > > > > > > > > > > > > > > > > Am Mittwoch, den 02.06.2021, 15:58 +0200 schrieb > > > > > > > > > > Jean- > > > > > > > > > > Louis > > > > > > > > > > Monteiro: > > > > > > > > > > > The 2 first and the last one. > > > > > > > > > > > Trying to understand the async-servlet related > > > > > > > > > > > issues. > > > > > > > > > > > For the > > > > > > > > > > > 2 last > > > > > > > > > > > cxf-rs, I'd need David's input > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > Jean-Louis Monteiro > > > > > > > > > > > http://twitter.com/jlouismonteiro > > > > > > > > > > > http://www.tomitribe.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Jun 2, 2021 at 9:56 AM Zowalla, Richard < > > > > > > > > > > > [email protected]> wrote: > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > > > thanks for the work! Hopefully, we are soon > > > > > > > > > > > > green > > > > > > > > > > > > again > > > > > > > > > > > > and > > > > > > > > > > > > can go > > > > > > > > > > > > for > > > > > > > > > > > > 8.0.8 > > > > > > > > > > > > > > > > > > > > > > > > Can you provide more information, which tests > > > > > > > > > > > > might > > > > > > > > > > > > not > > > > > > > > > > > > be > > > > > > > > > > > > relevant? > > > > > > > > > > > > > > > > > > > > > > > > Looks like, that it isn't possible to disable > > > > > > > > > > > > the > > > > > > > > > > > > johnzon > > > > > > > > > > > > provider > > > > > > > > > > > > via > > > > > > > > > > > > "org.apache.openejb.server.cxf.rs.johnzon.TomEE > > > > > > > > > > > > Jo > > > > > > > > > > > > hnzo > > > > > > > > > > > > nP > > > > > > > > > > > > rovide > > > > > > > > > > > > r.acti > > > > > > > > > > > > vate > > > > > > > > > > > > d" anymore. This is something, which was > > > > > > > > > > > > mentioned in > > > > > > > > > > > > [1] by > > > > > > > > > > > > Romain. > > > > > > > > > > > > > > > > > > > > > > > > Gruss > > > > > > > > > > > > Richard > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-3742 > > > > > > > > > > > > > > > > > > > > > > > > Am Montag, den 31.05.2021, 14:04 +0200 schrieb > > > > > > > > > > > > Jean- > > > > > > > > > > > > Louis > > > > > > > > > > > > Monteiro: > > > > > > > > > > > > > Hello, > > > > > > > > > > > > > > > > > > > > > > > > > > Been trying to work on the build. > > > > > > > > > > > > > Created the following PR and kept improving > > > > > > > > > > > > > it > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/tomee/pull/800 > > > > > > > > > > > > > > > > > > > > > > > > > > Such as we are 9 failures only away from > > > > > > > > > > > > > green > > > > > > > > > > > > > build. > > > > > > > > > > > > > Some > > > > > > > > > > > > failures > > > > > > > > > > > > > might > > > > > > > > > > > > > not be relevant and require you to remove the > > > > > > > > > > > > > tests > > > > > > > > > > > > > or > > > > > > > > > > > > > change > > > > > > > > > > > > them. > > > > > > > > > > > > > But > > > > > > > > > > > > > I'll need some help from David who worked > > > > > > > > > > > > > quite > > > > > > > > > > > > > heavily on > > > > > > > > > > > > > CXF so > > > > > > > > > > > > I > > > > > > > > > > > > > don't > > > > > > > > > > > > > have to pay that same cost. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://ci-builds.apache.org/job/Tomee/job/pull-request/lastBuild/testReport/ > > > > > > > > > > > > > I'm trying to address the websocket failures > > > > > > > > > > > > > but > > > > > > > > > > > > > any > > > > > > > > > > > > > help > > > > > > > > > > > > > is > > > > > > > > > > > > welcome > > > > > > > > > > > > > as > > > > > > > > > > > > > usual > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > Jean-Louis Monteiro > > > > > > > > > > > > > http://twitter.com/jlouismonteiro > > > > > > > > > > > > > http://www.tomitribe.com > > > -- > > > Richard Zowalla, M.Sc. > > > Research Associate, PhD Student | Medical Informatics > > > > > > Hochschule Heilbronn – University of Applied Sciences > > > Max-Planck-Str. 39 > > > D-74081 Heilbronn > > > phone: +49 7131 504 6791 (zur Zeit nicht via Telefon erreichbar) > > > mail: [email protected] > > > web: https://www.mi.hs-heilbronn.de/ > > >
