That sounds great Cesar. Thanks -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com
On Fri, Apr 29, 2022 at 5:48 AM Cesar Hernandez <cesargu...@gmail.com> wrote: > Thank you for the list, Richard, > > If there is no objection, I propose to create a > https://github.com/apache/tomee/javaxToJakartaNamespace.adoc to keep > track > of the shaded versions we currently have, common dependencies that will > need to be updated, and strategies to troubleshooting common issues and > link to the main epic https://issues.apache.org/jira/browse/TOMEE-3862. > > WDYT? > > > > El mié, 27 abr 2022 a las 0:23, Zowalla, Richard (< > richard.zowa...@hs-heilbronn.de>) escribió: > > > Hi, > > > > I am not aware of any public reference list. There are some things, > > which floated around the mailing list or in the heads, which are: > > > > - Javamail is currently broken. We need to have a jakarta compatible > > version of Geronimo Javamail. This currently breaks 2 examples and > > prevents platform tck from running. > > > > - Deltaspike / Kratzo examples require dependency upgrades, i.e. MVC > > 2.0 + Jakarta version of Deltaspike. > > > > - Micro Profile examples are broken due to the ongoing integration work > > of SmallRye impls. If the integration is done, we can fix them. > > > > - If Hibernate is used, we either need to upgrade to 6.0.0 _or_ use the > > Jakarta artifact from the 5.6.x series. In some examples, we still use > > Hibernate 4, so the upgrade also requires to deal with > > "tomee.jpa.factory.lazy". > > > > - Check for "http" repositories to avoid the default http blocker in > > newer Maven versions. > > > > Gruß > > Richard > > > > > > Am Dienstag, dem 26.04.2022 um 21:28 -0600 schrieb Cesar Hernandez: > > > Hi all, > > > > > > Late last week I started to pick and create sub-task related to > > > https://issues.apache.org/jira/browse/TOMEE-3862. > > > The current CI master status [1] has helped me to identify tests that > > > need > > > fixes, examples that need dependencies updates to match the javax. -> > > > jakarta , etc. > > > > > > Do we have a place where we can check the list of knowing-Issue and > > > knowing-fixes a contributor can take as a reference when trying to > > > fix a > > > subtask from TOMEE-3862 ? > > > For example, today I faced a javax/servlet issue [2] that required > > > some > > > dependencies replacements like jstl [3 ] with > > > jakarta.servlet.jsp.jstl-api > > > [4] and taglibs:standard [5] with taglibs-shade [6]. > > > > > > > > > [1] > > > https://ci-builds.apache.org/job/Tomee/job/master-build-full/ > > > > > > [2] > > > > > > Caused by: java.lang.NoClassDefFoundError: > > > javax/servlet/jsp/tagext/TagSupport > > > > > > > > > [3] > > > <groupId>javax.servlet</groupId> > > > <artifactId>jstl</artifactId> > > > <version>1.1.2</version> > > > > > > [4] > > > <groupId>jakarta.servlet.jsp.jstl</groupId> > > > <artifactId>jakarta.servlet.jsp.jstl-api</artifactId> > > > <version>2.0.0</version> > > > > > > [5] > > > <groupId>taglibs</groupId> > > > <artifactId>standard</artifactId> > > > <version>1.1.2</version> > > > > > > [6] > > > <groupId>org.apache.tomee</groupId> > > > <artifactId>taglibs-shade</artifactId> > > > <version>9.0.0-M8-SNAPSHOT</version> > > > > > > > > > El mié, 30 mar 2022 a las 1:20, Jean-Louis Monteiro (< > > > jlmonte...@tomitribe.com>) escribió: > > > > > > > Thanks Richard. > > > > > > > > I got personal issues with my computer and it's taking a bit of > > > > time to set > > > > everything up again. > > > > > > > > > > > > -- > > > > Jean-Louis Monteiro > > > > http://twitter.com/jlouismonteiro > > > > http://www.tomitribe.com > > > > > > > > > > > > On Wed, Mar 30, 2022 at 8:45 AM Zowalla, Richard < > > > > richard.zowa...@hs-heilbronn.de> wrote: > > > > > > > > > Update regarding TOMEE-3879: We were missing --add-opens options > > > > > in the > > > > > failover tests to run with Java 11+ - we added it to the bat / sh > > > > > scripts of openejb-standalone. However, bat / sh is not used in > > > > > the > > > > > failover tests. > > > > > > > > > > I added the options in the tests, so TOMEE-3879 is fixed now. > > > > > > > > > > Gruß > > > > > Richard > > > > > > > > > > Am Dienstag, dem 29.03.2022 um 06:53 +0000 schrieb Zowalla, > > > > > Richard: > > > > > > Hi, > > > > > > > > > > > > to follow up on TOMEE-3879 [1]: I add some more context to the > > > > > > Jira. > > > > > > The permissions do not matter as we are not invoking the > > > > > > scripts in > > > > > > bin/* in the failover itests (itests/failover). > > > > > > > > > > > > We are directly booting the servers via the java command (via > > > > > > Bootstrap > > > > > > from openejb-core) and a lot of properties to configure it, > > > > > > which > > > > > > fails > > > > > > (at least for me atm) with a ClassNotFoundException (see > > > > > > issue). Due > > > > > > to > > > > > > this exception, the servers never become ready and the tests > > > > > > will > > > > > > just > > > > > > timeout. > > > > > > > > > > > > Don't have time to dig into it now but hope it helps anyone, > > > > > > who will > > > > > > work on it in the near future :) > > > > > > > > > > > > Gruß > > > > > > Richard > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/TOMEE-3879 > > > > > > > > > > > > Am Montag, dem 28.03.2022 um 08:16 +0000 schrieb Zowalla, > > > > > > Richard: > > > > > > > Heyho, > > > > > > > > > > > > > > the ZIP created for TOMEE-3879 looks good to me. It has +x > > > > > > > set. > > > > > > > Perhaps > > > > > > > it looses the info during extraction in our code. > > > > > > > > > > > > > > Can you give a pointer, which tests are suspected to be > > > > > > > impacted by > > > > > > > it? > > > > > > > > > > > > > > Gruß > > > > > > > Richard > > > > > > > > > > > > > > Am Samstag, dem 26.03.2022 um 10:40 +0100 schrieb Jean-Louis > > > > > > > Monteiro: > > > > > > > > Awesome, divide and conquer. > > > > > > > > > > > > > > > > Trying to add a bit more... > > > > > > > > This one might be small for someone with some spare cycles. > > > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/TOMEE-3879 > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Jean-Louis Monteiro > > > > > > > > http://twitter.com/jlouismonteiro > > > > > > > > http://www.tomitribe.com > > > > > > > > > > > > > > > > > > > > > > > > On Sat, Mar 26, 2022 at 5:35 AM David Blevins < > > > > > > > > david.blev...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > On Mar 24, 2022, at 2:28 AM, Jean-Louis Monteiro < > > > > > > > > > jlmonte...@tomitribe.com> wrote: > > > > > > > > > > We can now divide and conquer. An issue has been > > > > > > > > > > created > > > > > > > > > > https://issues.apache.org/jira/browse/TOMEE-3862 > > > > > > > > > > We are going to add as many small tasks as possible so > > > > > > > > > > people > > > > > > > > > > can > > > > > > > > > > pick > > > > > > > > > and > > > > > > > > > > contribute in parallel. > > > > > > > > > > > > > > > > > > Thanks for that JIRA. I saw an easy one I could do and > > > > > > > > > went a > > > > > > > > > head > > > > > > > > > and > > > > > > > > > knocked it out :) > > > > > > > > > > > > > > > > > > - > > > > > > > > > > > > > > > > https://github.com/apache/tomee/commit/6e37ec02ca60fe955a3a909d761e09aa5a506978 > > > > > > > > > That yanks 1 minute out of the build on my machine. > > > > > > > > > > > > > > > > > > > > > > > > > > > -David > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Mar 22, 2022 at 1:59 PM Jean-Louis Monteiro < > > > > > > > > > > jlmonte...@tomitribe.com> wrote: > > > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > I've been working for quite a long time on TomEE 9.x, > > > > > > > > > > > and > > > > > > > > > > > it's > > > > > > > > > > > been more > > > > > > > > > > > challenging and painful than I was expecting. I > > > > > > > > > > > thought it > > > > > > > > > > > would be > > > > > > > > > good to > > > > > > > > > > > give you some sort of status. > > > > > > > > > > > > > > > > > > > > > > I created a PR for the work. As a reminder, since > > > > > > > > > > > Java EE > > > > > > > > > > > moved > > > > > > > > > > > to > > > > > > > > > Eclipse > > > > > > > > > > > to become Jakarta EE, we had a switch from javax.* > > > > > > > > > > > namespace > > > > > > > > > > > to > > > > > > > > > jakarta.* > > > > > > > > > > > namespace. This is an impacting change, since all > > > > > > > > > > > applications > > > > > > > > > > > and > > > > > > > > > > > applications servers are built on top of it. > > > > > > > > > > > > > > > > > > > > > > In TomEE, we decided to do that change in TomEE. We > > > > > > > > > > > had > > > > > > > > > > > previously a > > > > > > > > > > > bytecode change approach like an application could > > > > > > > > > > > do. It > > > > > > > > > > > worked and we > > > > > > > > > > > were able to get certified. But it had a lot of > > > > > > > > > > > limitations, > > > > > > > > > > > so > > > > > > > > > > > we had > > > > > > > > > to > > > > > > > > > > > do the migration in the code and fix all > > > > > > > > > > > compatibility > > > > > > > > > > > issues. > > > > > > > > > > > > > > > > > > > > > > Here is the PR > > > > > > > > > > > https://github.com/apache/tomee/pull/814 > > > > > > > > > > > It has 90+ commits and nearly 5000 files touched > > > > > > > > > > > (added, > > > > > > > > > > > removed, > > > > > > > > > > > updated). I understand it's a lot and it makes it > > > > > > > > > > > almost > > > > > > > > > > > impossible to > > > > > > > > > > > review. But I did not see much approaches in this > > > > > > > > > > > scenario > > > > > > > > > > > to > > > > > > > > > > > create > > > > > > > > > > > smaller PRs. > > > > > > > > > > > > > > > > > > > > > > I created a Jenkins build though available at > > > > > > > > > > > > > > > > https://ci-builds.apache.org/job/Tomee/job/master-build-quick-9.x/ > > > > > > > > > > > It makes it possible to track the progress. There > > > > > > > > > > > have been > > > > > > > > > > > steps > > > > > > > > > forward > > > > > > > > > > > and steps backward. > > > > > > > > > > > > > > > > > > > > > > All the code does not sit under TomEE, we use a bunch > > > > > > > > > > > of > > > > > > > > > > > third > > > > > > > > > > > party > > > > > > > > > > > projects and libraries. I have been able to > > > > > > > > > > > contribute, > > > > > > > > > > > publish > > > > > > > > > > > jakarta > > > > > > > > > > > compatible versions and get releases for some of them > > > > > > > > > > > (Jakarta > > > > > > > > > > > EE APIs > > > > > > > > > Uber > > > > > > > > > > > jar, Geronimo Connectors and Transaction Manager, > > > > > > > > > > > Geronimo > > > > > > > > > > > Config, > > > > > > > > > Health, > > > > > > > > > > > Metrics, OpenTracing, OpenAPI. OpenJPA, BVal, and > > > > > > > > > > > OpenWebBeans > > > > > > > > > > > will be > > > > > > > > > > > released soon. > > > > > > > > > > > > > > > > > > > > > > The big parts is CXF, and ActiveMQ. I had to get them > > > > > > > > > > > done > > > > > > > > > > > in > > > > > > > > > > > TomEE and > > > > > > > > > > > update all group/artifact ids. It's under deps, > > > > > > > > > > > alongside > > > > > > > > > > > with > > > > > > > > > > > SXC, > > > > > > > > > DBCP, > > > > > > > > > > > and others. > > > > > > > > > > > > > > > > > > > > > > In terms of removal, I tried to remove old stuff like > > > > > > > > > > > SAAJ > > > > > > > > > > > Axis > > > > > > > > > > > 1 > > > > > > > > > > > integration, JAX RPC, Management J2EE and a couple of > > > > > > > > > > > other > > > > > > > > > > > old > > > > > > > > > > > things. > > > > > > > > > > > > > > > > > > > > > > A lot of other libraries got updated to their latest > > > > > > > > > > > version > > > > > > > > > > > when > > > > > > > > > > > available in the new jakarta namespace. > > > > > > > > > > > > > > > > > > > > > > I'm starting to get all the build stable and many > > > > > > > > > > > modules > > > > > > > > > > > are > > > > > > > > > > > passing > > > > > > > > > now, > > > > > > > > > > > including all CXF webservices, OpenEJB Core, and > > > > > > > > > > > others. I > > > > > > > > > > > can > > > > > > > > > > > get a > > > > > > > > > build > > > > > > > > > > > and run TomEE. > > > > > > > > > > > > > > > > > > > > > > Goal is to get a green build asap so we can start > > > > > > > > > > > working > > > > > > > > > > > on > > > > > > > > > > > TCK. > > > > > > > > > > > The "quick" build is now green. Working on the full > > > > > > > > > > > build. > > > > > > > > > > > > > > > > > > > > > > I'll soon be creating a branch for TomEE 8.x > > > > > > > > > > > maintenance > > > > > > > > > > > and > > > > > > > > > > > merge the > > > > > > > > > PR. > > > > > > > > > > > I'm hoping we can then have small PRs or at least > > > > > > > > > > > more > > > > > > > > > > > people > > > > > > > > > > > working in > > > > > > > > > > > parallel. > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > Jean-Louis Monteiro > > > > > > > > > > > http://twitter.com/jlouismonteiro > > > > > > > > > > > http://www.tomitribe.com > > > > > > > > > > > > > > > > -- > > > > > Richard Zowalla, M.Sc. > > > > > Research Associate, PhD Student | Medical Informatics > > > > > > > > > > Hochschule Heilbronn – University of Applied Sciences > > > > > Max-Planck-Str. 39 > > > > > D-74081 Heilbronn > > > > > phone: +49 7131 504 6791 (zur Zeit nicht via Telefon erreichbar) > > > > > mail: richard.zowa...@hs-heilbronn.de > > > > > web: https://www.mi.hs-heilbronn.de/ > > > > > > > > > > > > > > > > -- > Atentamente: > César Hernández. >
