This comes up every few years. Note, we did make a few contributions to dbcp in 2007-2008 because at that time it didn’t support transactional connection pooling.
Here’s the issue where we patched it: - https://issues.apache.org/jira/browse/DBCP-228 We’d want to make sure that the Tomcat connection pooling also supports XA and we can pass any JTA-related tests in the TCK. We might not be running those. I did a quick bytecode scan and it does appear that tomcat-dbcp.jar uses the Jakarta Transaction APIs. Tomcat doesn’t ship that API, however, so we’d still need to verify how well JTA is actually supported. class name jakarta.transaction uses org/apache/tomcat/dbcp/dbcp2/managed/TransactionContext.class 40 org/apache/tomcat/dbcp/dbcp2/managed/TransactionRegistry.class 23 org/apache/tomcat/dbcp/dbcp2/managed/BasicManagedDataSource.class 19 org/apache/tomcat/dbcp/dbcp2/managed/DataSourceXAConnectionFactory.class 17 org/apache/tomcat/dbcp/dbcp2/managed/LocalXAConnectionFactory.class 7 org/apache/tomcat/dbcp/dbcp2/managed/SynchronizationAdapter.class 1 It might be Dain’s changes were backported though Tomcat doesn’t itself support JTA. -David > On May 26, 2023, at 3:32 AM, Richard Zowalla <[email protected]> wrote: > > Hi all, > > it seems that dbcp2 has no real intention to provide us with "real" > jakarta packages. If we want to drop the shade artifact in TomEE 9 / > 10, we would need to drop our dbcp2 integration (or stick with the > shading). > > Do we have any good reason to keep it in TomEE 9 / 10? Otherwise, - > based on Romains comment below - I am inclined to just drop it? Wdyt? > > > Gruß > Richard > > -------- Ursprüngliche Nachricht -------- > Von: Romain Manni-Bucau <[email protected]> > Antwort an: Commons Developers List <[email protected]> > An: Commons Developers List <[email protected]> > Betreff: Re: Jakarta namespace in commons like dbcp - thoughts / ideas? > Datum: Fri, 26 May 2023 12:20:59 +0200 > >> Hi Richard, >> >> TomEE can drop managed package legacy dependency now, was kept while >> the >> replacement was in test in 1.x version but makes years it is no more >> relevant and no more the default (since we switched to tomcat-jdbc). >> So no big deal if dbcp wants to drop it on TomEE side IMHO. >> >> Romain Manni-Bucau >> @rmannibucau <https://twitter.com/rmannibucau> | Blog >> <https://rmannibucau.metawerx.net/> | Old Blog >> <http://rmannibucau.wordpress.com> | Github >> <https://github.com/rmannibucau> | >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book >> < >> https://www.packtpub.com/application-development/java-ee-8-high-perfor >> mance> >> >> >> Le ven. 26 mai 2023 à 12:19, Richard Zowalla <[email protected]> a >> écrit : >> >>> The current TomEE codebase still uses classes from the "managed" >>> package of dbcp2. (Thus, we are shading it for TomEE 9 / 10) >>> >>> We might be able to drop that integration at some point but >>> currently >>> our focus is on getting a EE10 milestone out of the door, so I >>> don't >>> think, that it is a theoretical issue. >>> >>> Gruß >>> Richard >>> >>> >>> Am Freitag, dem 26.05.2023 um 12:08 +0200 schrieb Emmanuel Bourg: >>>> Le 11/05/2023 à 15:56, Richard Zowalla a écrit : >>>>> Hi, >>>>> >>>>> do we have any updates? >>>>> >>>>> How can I help to get a dbcp version supporting Jakarta >>>>> namespace? >>>>> >>>>> Emmanuel outlined a possible appraoch. How can we move forward >>>>> with >>>>> it? >>>> >>>> I'm tempted to merge the dual-javax-jakarta branch, but Romain's >>>> comment >>>> about TomEE no longer using the managed package made me wonder if >>>> we >>>> really need to bother at all. >>>> >>>> Are we trying to fix a theoretical issue or are there actual >>>> users of >>>> these classes expecting a fix? >>>> >>>> Emmanuel Bourg >>>> >>>> >>>> ----------------------------------------------------------------- >>>> ---- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>> >>> >>> ------------------------------------------------------------------- >>> -- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >
