Hi! Unfortunately, I didn't get very far with the faces tck, but maybe there is another task that I could deal with in parallel? Maybe I'll find a solution to the faces tck task in the meantime. What do you think?
Thanks: Zoltán On Fri, Jan 20, 2023 at 2:18 AM David Blevins <[email protected]> wrote: > Hi Zoltán, > > > On Jan 18, 2023, at 12:22 PM, Zoltán Tichov <[email protected]> > wrote: > > > > Ok, but eg. the JsonB TCK is more or less in one jar file and at Jakarta > > TCK is not that case. > > So I think I cannot put the whole Faces TCK in one jar to include as a > > dependency. Or I put the whole faces tck > > in the tomee/tck? > > I’d say make a directory for faces under tomee/tck/ and do your best to > set things up the way you think makes the most sense. That could be one > module or several modules. > > The trick with tomee-tck is that what’s there is a single module project > dedicated to the old testing framework all of Java EE, including JSF, used > to use. It’s horrifically complicated and we have an even more complicated > codebase in tomee-tck to deal with it; it’s an odd combination of shell > scripts, ant scripts, groovy, java and properties files. > > As part of EE 10 the Faces team migrated the tests out of that old > framework to Arquillian and now those test are no longer runnable with what > is there in tomee-tck. > > The only way we could make the new tests runnable in tomee-tck is > basically to move all the code into a directory, ignore that directory, and > create a completely new setup from scratch next to it. We may want to do > that, but for now everyone is putting setups for the new tests under > tomee/tck. > > > -David > > > > > > On Wed, Jan 18, 2023 at 8:46 PM David Blevins <[email protected]> > > wrote: > > > >> Hi Zoltán! > >> > >>> On Jan 18, 2023, at 11:31 AM, Zoltán Tichov <[email protected]> > >> wrote: > >>> > >>> Hi! > >>> > >>> I examined the Jakarta Faces TCK and it appears that the setup could be > >>> done in the same way as tomee-tck is. > >>> But I don't know if it could merge the two TCK or the faces TCK should > >> be a > >>> separate project. > >>> Which direction should I go? > >> > >> All the other standalone TCKs are currently setup here: > >> > >> - https://github.com/apache/tomee/tree/main/tck > >> > >> Here’s a couple similar PRs to use as reference: > >> > >> - https://github.com/apache/tomee/pull/1004 > >> - https://github.com/apache/tomee/pull/1003 > >> - https://github.com/apache/tomee/pull/1002 > >> > >> We may split those out at some point, but that’s where things seem to be > >> going for now. > >> > >> > >> -David > >> > >>> On Thu, Jan 12, 2023 at 12:47 PM Jonathan Gallimore < > >>> [email protected]> wrote: > >>> > >>>> I've started wiring up the Concurrency TCK here: > >>>> https://github.com/apache/tomee/tree/TOMEE-4159_Concurrency_TCK. > After > >>>> updating the Jakarta EE API to 10, there are some compile issues, > >>>> particularly around the concurrency area, so there is some work to do > >>>> (which I'm looking at now!). > >>>> > >>>> Cheers > >>>> > >>>> Jon > >>>> > >>>> On Thu, Jan 12, 2023 at 11:41 AM Jean-Louis Monteiro < > >>>> [email protected]> wrote: > >>>> > >>>>> I saw some commits. Thanks for the setup and the work. > >>>>> We have a couple of pending PRs ready for the different TCK (BVal, > CDI, > >>>>> JSONB, JSONP, Concurrent). > >>>>> > >>>>> The challenge with standalone TCK is that if we don't find a way to > run > >>>>> them on the cloud, we'll need to consolidate the results between the > 2 > >>>>> platforms. It will be definitely slower on the Apache CI system and > >> will > >>>>> make the build unbelievably slow. > >>>>> > >>>>> We have some investment there. We can of course run in the cloud with > >>>> `mvn > >>>>> verify -pl tck/bval-tomee` etc. But how are we going to collect the > >>>>> results? Furthermore for CDI and others, it would be great to split > >> into > >>>>> smaller chunks to run in parallel. > >>>>> > >>>>> > >>>>> Long story short, there is some good investment to have on this area. > >> It > >>>>> will definitely pay off in the long run. > >>>>> > >>>>> -- > >>>>> Jean-Louis Monteiro > >>>>> http://twitter.com/jlouismonteiro > >>>>> http://www.tomitribe.com > >>>>> > >>>>> > >>>>> On Thu, Jan 12, 2023 at 2:54 AM David Blevins < > [email protected] > >>> > >>>>> wrote: > >>>>> > >>>>>>> On Jan 4, 2023, at 4:00 PM, David Blevins <[email protected] > > > >>>>>> wrote: > >>>>>>> > >>>>>>> I created JIRAs for all the individual TCKs involved in EE 10. > Some > >>>> of > >>>>>> these are already setup: > >>>>>>> > >>>>>>> TOMEE-4156 Platform/WebProfile TCK > >>>>>> > >>>>>> I have this at least minimally setup here: > >>>>>> > >>>>>> - https://github.com/apache/tomee-tck > >>>>>> > >>>>>> There’s a `setup.sh` that will download and install the Jakarta EE > 10 > >>>>>> Platform & Web Profile TCK on your machine. > >>>>>> > >>>>>> General FYI on some tweaks I made to the branches. > >>>>>> > >>>>>> - main: now points to TomEE 10 instead of TomEE 8 > >>>>>> - tomee-8.x: new branch made from the former `main` branch, > dedicated > >>>> to > >>>>>> TomEE 8 > >>>>>> - tomee-8.x: new branch made from the `jakartaee9-tck` branch, > >>>> dedicated > >>>>>> to TomEE 9 > >>>>>> > >>>>>> Next steps for me will be trying to get a run or two going up in the > >>>>> cloud > >>>>>> so we have some base numbers. Quite a lot of the tests were moved > out > >>>> to > >>>>>> standalone TCKs, so there’ll some work to get a good view of how > >> things > >>>>>> compare. > >>>>>> > >>>>>> > >>>>>> -David > >>>>>> > >>>>>> > >>>>> > >>>> > >> > >> > >
