Hey David, I saw your commits. I'm ok to contribute to TCK first so there is only one thing updated and we know it's the setup if we get TCK failures. The changes I made are in a PR for the bigger part. Only the Tomcat update has been already pushed to main. But I'm happy to revert it. It's usually compatible, especially from 10.0 to 10.1.
All the TCK setup changed. Did you look at them and have an idea on how to rework our tomee-tck project to run them? I'm glad they changed it so hopefully we can get a simpler setup. Also wondering if we could have them like MicroProfile TCK, CDI or BVal for instance in the project itself? Then the way to run them efficiently, split or use ec2 is another problem. What do you think? -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Jan 5, 2023 at 1:00 AM David Blevins <david.blev...@gmail.com> wrote: > I created JIRAs for all the individual TCKs involved in EE 10. Some of > these are already setup: > > TOMEE-4156 Platform/WebProfile TCK > TOMEE-4157 Jakarta Authentication TCK > TOMEE-4158 Jakarta Bean Validation TCK > TOMEE-4159 Jakarta Concurrency TCK > TOMEE-4160 Jakarta Contexts and Dependency Injection (including > Language Model TCK) > TOMEE-4161 Jakarta Debugging Support for Other Languages TCK > TOMEE-4162 Jakarta Dependency Injection TCK > TOMEE-4163 Jakarta Faces TCK > TOMEE-4164 Jakarta JSON Binding TCK > TOMEE-4165 Jakarta JSON Processing TCK > TOMEE-4166 Jakarta RESTFul Web Services TCK > TOMEE-4167 Jakarta Security TCK > > General status is the TCKs were majorly refactored and reworked in EE 10 > and there will be considerable work to get a running TCK setup again. > > My suggestion would be we get these setup before we start tearing into the > TomEE 10 code. My gut says it would be a nightmare for someone to have to > set these up after a bunch of work has already been done and we don’t know > if failures are related to the tests not being setup correctly or if > failures are due to code changes or library upgrades. > > I see we’ve already started upgrading libraries, etc. but maybe we want to > pause or even revert them and redo that once we know we have functioning > TCK setup? > > Thoughts? > > > -David > > > > > On Jan 4, 2023, at 12:11 PM, Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > > > > Hi all, > > > > Looks like the TomEE 9.0.0 final release is in good shape and the vote is > > about to pass. Awesome. > > > > I'm already looking forward to TomEE 10.x. To that regard, I created a > > branch for 9.x maintenance already. Moved main to 10.0.0-SNAPSHOT. I > > upgraded Tomcat already and I'm looking to upgrade CXF to its latest > > jakarta version. I decided to remove all the shading and patching all > > together so we get back to a Maven based dependency. We can cherry pick > on > > demand or even contribute to CXF if they are willing to accept the > > contributions. > > > > Here are a set of small actions before we enter into the actual game of > > supporting Jakarta EE 10 and MicroProfile 6.0 > > > > TODOs: > > - create jobs for TomEE 9.x maintenance > > - update tomee-tck to create a new branch for 10.x > > - update tomee-tck > > - release 9.1 API final (we have M2 for 9.0.0 final which is ok, but we > > should release it so next time it's included). > > - create 10.x API and release a M1 > > > > Who can help on what? > > Creating a JIRA with sub tasks so we can track the work to do and > > coordinate is also a good contribution. > > > > -- > > Jean-Louis Monteiro > > http://twitter.com/jlouismonteiro > > http://www.tomitribe.com > >
