The issue cited was where I found it because I had automation that had weakly typed payloads as was permissible via perl. Once I upgraded to a version that had been converted to Go, the automation broke. I can fairly easily fix it in my code, but API are contracts and I object to retroactively invalidating semantically what once was permissible. It's a good and healthy thing to embrace strong typing and we should convert, but if I was heavily invested or behind a blackbox client that couldn't be updated this would prevent an upgrade to 3.x. If we're ok documenting this via this issue as a known issue, I'll retract my -1 with the group consensus.
Jonathan G On 2/6/19, 9:57 AM, "Dave Neuman" <[email protected]> wrote: Do you have an example of an endpoint that is in the 3.0 release that will not work now because of this bug? I think we should take a look at what is effected and make our decision from there. A release is not guaranteed to have no known issues, but we do need to decide if we can live with the known issues (and document them) or not. Thanks, Dave On Wed, Feb 6, 2019 at 9:37 AM Gray, Jonathan <[email protected]> wrote: > I'm -1 on the release because of issue > https://github.com/apache/trafficcontrol/issues/3304 . The conversion to > go from perl has inconsistent strong/weak typing implementation inside the > json payloads. The Traffic Portal is the primary client that's been > checked and converted to strong typing. Any client who was relying on weak > typing in the TO API will break; such as a default, simple usage of ansible. > > Jonathan G > > > On 2/1/19, 11:52 AM, "Gelinas, Derek" <[email protected]> wrote: > > Hello All, > I've prepared a release for v3.0.0-RC4 > The vote is open for at least 72 hours and passes if a majority of at > least 3 +1 PPMC votes are cast. > [ ] +1 Approve the release > [ ] -1 Do not release this package because ... > Changes since 2.2 > > https://github.com/apache/trafficcontrol/compare/2.2.x...RELEASE-3.0.0-RC4 > This corresponds to git: > Hash: 91b2edbcb4be8d38902160b7a4e28378aa5fb3f1 > Tag: RELEASE-3.0.0-RC4 > Which can be verified with the following: git tag -v RELEASE-3.0.0-RC4 > My code signing key is available here: > http://keys.gnupg.net/pks/lookup?search=0x05BE71D9&op=vindex > Make sure you refresh from a key server to get all relevant signatures. > The source .tgz file, pgp signature (.asc signed with my key from > above), and sha512 checksums are provided here: > https://dist.apache.org/repos/dist/dev/trafficcontrol/3.0.0/RC4/ > Thanks! > Derek > > > >
