Thanks Simon, my comments inline. On Mon, Dec 15, 2008 at 2:15 PM, Simon Laws <[email protected]>wrote:
> Hi Ram > > I started taking a look over the weekend. Haven't got through testing > samples yet but an initial observation on size > > binary distro is 103M in 1.4, was 64M in 1.3.2 > > Tutorial store-test > Ships with a jar that has a java core in it. I believe, this got in accidentally. I will fix this one. > > > Should we ship tutorials with target dirs? I think we should remove and > have people build them. > The catalog-webapp has a full set of libs and is 8M The tutorials README does are advise the users to compile them before running it, if we are planning to remove the target dirs from the tutorials then the README need to be updated accordingly. > > > demo/bigbank-* > now has target dirs where there were no target dirs in 1.3.2 > interestingly other demos are missing target dirs which were present in > 1.3.2 > I don't think we need target dirs in demos This was done with TUSCANY-2712, probably we need to evaluate whether we should have them or not. > > > Also interestingly lib/jaxb-api-2.1.jar > > 89K in 1.3.2 > 104K in 1.4 > > + License file > + ContextFined$2.class > > Must have been updated on the maven repos. Doesn't seem to be any impact. > > Also I think we need to make a few more changes around the contribution > xsd. I'll check in another change shortly. > > I'll also take a look at samples etc. > > Regards > > Simon > > > > -- Thanks & Regards, Ramkumar Ramalingam
