On Fri, Feb 13, 2009 at 2:29 PM, Simon Laws <simonsl...@googlemail.com>wrote:
> > > On Fri, Feb 13, 2009 at 11:33 AM, ant elder <ant.el...@gmail.com> wrote: > >> >> >> On Tue, Feb 10, 2009 at 9:52 AM, ant elder <ant.el...@gmail.com> wrote: >> >>> Please vote on releasing the Tuscany Maven Eclipse Compiler module. The >>> tag for the release is: >>> >>> >>> https://svn.apache.org/repos/asf/tuscany/maven-plugins/tags/maven-eclipse-compiler-1.0/ >>> >>> the Maven staging repository is: >>> >>> http://people.apache.org/~antelder/tuscany/maven-eclipse-compiler-1.0/<http://people.apache.org/%7Eantelder/tuscany/maven-eclipse-compiler-1.0/> >>> >>> ...ant >>> >>> >> Adding my vote to remind people this is pending still. >> >> +1 >> >> Also, in case the location of the tag is bothering anyone we can put the >> tag anywhere we like and can rename and move the tag after the release vote >> as we do with the SCA releases, eg i've just copied it to >> https://svn.apache.org/repos/asf/tuscany/tags/java/maven-eclipse-compiler-1.0/ >> >> ...ant >> >> >> Just ran a build from the staging repo. Didn't get a clean build but I > don't think that's this plugin's fault. > > B.t.w. For anyone wishing to actually test this you'll need to change the > dependency in sca/pom.xml around line 461... > > <dependencies> > <dependency> > > <groupId>org.apache.tuscany.maven.plugins</groupId> > <artifactId>maven-eclipse-compiler</artifactId> > <version>1.0</version> > <scope>provided</scope> > </dependency> > </dependencies> > > The LICENSE/NOTICES are at the top level and signatures verify. > > I do notice that the artifact name is a little inconsistent re. how these > things usually appear, e.g. it should really be > <artifactId>maven-eclipse-compiler-plugin</artifactId>? However it's not > bothered me before otherwise I would have raised if on the original thread. > Not bothering me enought to -1 this vote unless someone finds another reason > to respin. > > +1 > > Simon > > Thanks for voting! Re the artifactid, i think thats as this isn't actually a maven "plugin" module its a compiler. Our other modules that are proper maven plugins do end in plugin, eg tools\maven\maven-bundle-plugin. ...ant
