Hi Nirmal, I've reviewed your latest update and it looks pretty good. I have a few suggestions to make it even better:
- Generate a simple HTML document around the SVG. That'll help set a title for the document, a link to the original composite (assuming it's online) and any other decoration you'd like to add around the diagram. - Use groups (<svg:g>) to nest the various shapes you're generating. This should help simplify your code as you won't have to worry about positioning related shapes (as they'll be naturally nested). - To help navigate nested composites and included composites, generate links to their diagrams (perhaps you've already done that but I couldn't see it with the example diagrams you've committed). - Position the titles below or above the services and references. Right now they're kind of mixed with the services / references. These are only suggestions. Think about about them and decide yourself if you think they're good ideas or not. At this point I think you know better than me what's feasible and what makes more sense... -- Jean-Sebastien On Sat, Aug 6, 2011 at 12:04 PM, C.S. Nirmal J. Fernando (JIRA) <dev@tuscany.apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/TUSCANY-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080446#comment-13080446 > ] > > C.S. Nirmal J. Fernando edited comment on TUSCANY-3496 at 8/6/11 7:03 PM: > -------------------------------------------------------------------------- > > Hi All, > > I have almost finished implementing the necessary requirements of Composite > Diagram Generator as per now, and starting to testing the tool. > > You can find the code up to date from > https://svn.apache.org/repos/asf/tuscany/collaboration/GSoC-2011-Nirmal/ > > Herewith I have attached 4 SVG images, created using the tool, and the 4 > attached composites files were created/modified just for the feature > validation process, thus may not be meaningful. > > Please download and open the SVG images using your web browser, then only > you'll get to see the 'inclusion' links working. Also you should place all 4 > SVG images in one place to get the links to work. > > PS: You may notice that the images are not scrollable, I couldn't find a way > to make SVG scrollable yet (I spent very little time on it ), for now you may > want to zoom in and out. > > Waiting for your comments! > > Thanks. > > was (Author: nirmal): > Hi All, > > I have almost finished implementing the necessary requirements of Composite > Diagram Generator as per now, and starting to testing the tool. > > You can find the code up to date from > https://svn.apache.org/repos/asf/tuscany/collaboration/GSoC-2011-Nirmal/ > > Herewith I have attached 4 SVG images, created using the tool, and the 4 > attached composites files were created/modified just for the feature > validation process, thus may not be meaningful. > > Please download and open the SVG images using your web browser, then only > you'll get to see the 'inclusion' links working. Also you should place all 4 > SVG images in one place to get the links to work. > > Waiting for your comments! > > Thanks. > >> Develop a simple tool that can be used to generate composite diagrams from >> the xml files >> ---------------------------------------------------------------------------------------- >> >> Key: TUSCANY-3496 >> URL: https://issues.apache.org/jira/browse/TUSCANY-3496 >> Project: Tuscany >> Issue Type: Wish >> Components: Java SCA Community Ideas >> Affects Versions: Java-SCA-1.x >> Reporter: Raymond Feng >> Assignee: C.S. Nirmal J. Fernando >> Labels: gsoc, gsoc2010, gsoc2011, mentor >> Attachments: Calculator.xml, Calculator_diagram.svg, >> CompositeDiagramGeneratorUsingBatik-Maven.zip, >> CompositeDiagramGeneratorUsingBatik.zip, MyValueComposite2.xml, >> MyValueComposite2_diagram.svg, proposed_design_1.jpg, store.xml, >> store_diagram.svg, supplychain.xml, supplychain_diagram.svg >> >> Original Estimate: 1m >> Remaining Estimate: 1m >> >> I'm looking a simple tool (web based or command) that can generate the >> composite diagrams from a list of composite files. One technology we can try >> is the Apache Batik project. >> http://xmlgraphics.apache.org/batik/ >> This tool can serve multiple purposes: >> 1) Help document our tutorials and samples >> 2) Be integrated with the SCA domain manager to visualize the SCA domain >> (contributions, composites, nodes etc) > > -- > This message is automatically generated by JIRA. > For more information on JIRA, see: http://www.atlassian.com/software/jira > > >
