Hi All,

On Sat, Aug 13, 2011 at 12:05 PM, Nirmal Fernando <nirmal070...@gmail.com>wrote:

>
>
> On Thu, Aug 11, 2011 at 8:20 PM, Nirmal Fernando 
> <nirmal070...@gmail.com>wrote:
>
>> Hi Jean,
>>
>> On Wed, Aug 10, 2011 at 11:16 AM, Jean-Sebastien Delfino <
>> jsdelf...@apache.org> wrote:
>>
>>> Hi Nirmal,
>>>
>>> I've reviewed your latest update and it looks pretty good. I have a
>>> few suggestions to make it even better:
>>>
>>> - Generate a simple HTML document around the SVG. That'll help set a
>>> title for the document, a link to the original composite (assuming
>>> it's online) and any other decoration you'd like to add around the
>>> diagram.
>>>
>>
>> I'll provide a HTML wrapper!
>>
>
> I have added the HTML wrapper (
> https://svn.apache.org/repos/asf/tuscany/collaboration/GSoC-2011-Nirmal/CompositeDiagramGeneratorUsingBatik/src/main/java/org/apache/tuscany/sca/impl/html/HTMLWrapper.java
> ).
>
> I used Canvg (http://code.google.com/p/canvg/) which was released under
> MIT license (compatible with Apache 2 license:
> http://www.apache.org/legal/resolved.html#category-a) and I included the
> two Java Script files of Canvg + the MIT license file under resources
> directory (
> https://svn.apache.org/repos/asf/tuscany/collaboration/GSoC-2011-Nirmal/CompositeDiagramGeneratorUsingBatik/resources/
> ).
>
> I think there is a procedure when including source from another license,
> which I am not familiar with!
>

I avoided using Canvg since, it is not needed. I modified the HTMLWrapper
code (
https://svn.apache.org/repos/asf/tuscany/collaboration/GSoC-2011-Nirmal/CompositeDiagramGeneratorUsingBatik/src/main/java/org/apache/tuscany/sca/impl/html/HTMLWrapper.java),
now it's simply embedding the svg document, inside a HTML.

>
>
>>
>>
>>>
>>> - Use groups (<svg:g>) to nest the various shapes you're generating.
>>> This should help simplify your code as you won't have to worry about
>>> positioning related shapes (as they'll be naturally nested).
>>>
>>
>> I'm not sure whether this is necessary, since the dimensions of artifacts
>> changes dynamically (i.e. according to their quantity), I should position
>> each artifact dynamically. You have different thoughts?
>>
>>
>>>
>>> - To help navigate nested composites and included composites, generate
>>> links to their diagrams (perhaps you've already done that but I
>>> couldn't see it with the example diagrams you've committed).
>>>
>>
>> Ya, I've already done that, please see "MyValueComposite2_diagram.svg"
>> from your web browser.
>>
>>
>>>
>>> - Position the titles below or above the services and references.
>>> Right now they're kind of mixed with the services / references.
>>>
>>
>> It was in displayed in the center of the services/references. I added them
>> to top of each service/reference!
>>
>>
>>>
>>> These are only suggestions. Think about about them and decide yourself
>>> if you think they're good ideas or not. At this point I think you know
>>> better than me what's feasible and what makes more sense...
>>>
>>
>> Thanks for the valuable thoughts!
>>
>>
>>> --
>>> Jean-Sebastien
>>>
>>> On Sat, Aug 6, 2011 at 12:04 PM, C.S. Nirmal J. Fernando (JIRA)
>>> <dev@tuscany.apache.org> wrote:
>>> >
>>> >    [
>>> https://issues.apache.org/jira/browse/TUSCANY-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080446#comment-13080446]
>>> >
>>> > C.S. Nirmal J. Fernando edited comment on TUSCANY-3496 at 8/6/11 7:03
>>> PM:
>>> >
>>> --------------------------------------------------------------------------
>>> >
>>> > Hi All,
>>> >
>>> > I have almost finished implementing the necessary requirements of
>>> Composite Diagram Generator as per now, and starting to testing the tool.
>>> >
>>> > You can find the code up to date from
>>> https://svn.apache.org/repos/asf/tuscany/collaboration/GSoC-2011-Nirmal/
>>> >
>>> > Herewith I have attached 4 SVG images, created using the tool, and the
>>> 4 attached composites files were created/modified just for the feature
>>> validation process, thus may not be meaningful.
>>> >
>>> > Please download and open the SVG images using your web browser, then
>>> only you'll get to see the 'inclusion' links working. Also you should place
>>> all 4 SVG images in one place to get the links to work.
>>> >
>>> > PS: You may notice that the images are not scrollable, I couldn't find
>>> a way to make SVG scrollable yet (I spent very little time on it ), for now
>>> you may want to zoom in and out.
>>>
>>
> I fixed this! :) Now you could see the whole diagram!
>
>
>>  >
>>> > Waiting for your comments!
>>> >
>>> > Thanks.
>>> >
>>> >      was (Author: nirmal):
>>> >    Hi All,
>>> >
>>> > I have almost finished implementing the necessary requirements of
>>> Composite Diagram Generator as per now, and starting to testing the tool.
>>> >
>>> > You can find the code up to date from
>>> https://svn.apache.org/repos/asf/tuscany/collaboration/GSoC-2011-Nirmal/
>>> >
>>> > Herewith I have attached 4 SVG images, created using the tool, and the
>>> 4 attached composites files were created/modified just for the feature
>>> validation process, thus may not be meaningful.
>>> >
>>> > Please download and open the SVG images using your web browser, then
>>> only you'll get to see the 'inclusion' links working. Also you should place
>>> all 4 SVG images in one place to get the links to work.
>>> >
>>> > Waiting for your comments!
>>> >
>>> > Thanks.
>>> >
>>> >> Develop a simple tool that can be used to generate composite diagrams
>>> from the xml files
>>> >>
>>> ----------------------------------------------------------------------------------------
>>> >>
>>> >>                 Key: TUSCANY-3496
>>> >>                 URL:
>>> https://issues.apache.org/jira/browse/TUSCANY-3496
>>> >>             Project: Tuscany
>>> >>          Issue Type: Wish
>>> >>          Components: Java SCA Community Ideas
>>> >>    Affects Versions: Java-SCA-1.x
>>> >>            Reporter: Raymond Feng
>>> >>            Assignee: C.S. Nirmal J. Fernando
>>> >>              Labels: gsoc, gsoc2010, gsoc2011, mentor
>>> >>         Attachments: Calculator.xml, Calculator_diagram.svg,
>>> CompositeDiagramGeneratorUsingBatik-Maven.zip,
>>> CompositeDiagramGeneratorUsingBatik.zip, MyValueComposite2.xml,
>>> MyValueComposite2_diagram.svg, proposed_design_1.jpg, store.xml,
>>> store_diagram.svg, supplychain.xml, supplychain_diagram.svg
>>> >>
>>> >>   Original Estimate: 1m
>>> >>  Remaining Estimate: 1m
>>> >>
>>> >> I'm looking a simple tool (web based or command) that can generate the
>>> composite diagrams from a list of composite files. One technology we can try
>>> is the Apache Batik project.
>>> >> http://xmlgraphics.apache.org/batik/
>>> >> This tool can serve multiple purposes:
>>> >> 1) Help document our tutorials and samples
>>> >> 2) Be integrated with the SCA domain manager to visualize the SCA
>>> domain (contributions, composites, nodes etc)
>>> >
>>> > --
>>> > This message is automatically generated by JIRA.
>>> > For more information on JIRA, see:
>>> http://www.atlassian.com/software/jira
>>> >
>>> >
>>> >
>>>
>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>>
>> C.S.Nirmal J. Fernando
>> Department of Computer Science & Engineering,
>> Faculty of Engineering,
>> University of Moratuwa,
>> Sri Lanka.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>>
> Thanks.
>
>
> --
> Best Regards,
> Nirmal
>
> C.S.Nirmal J. Fernando
> Department of Computer Science & Engineering,
> Faculty of Engineering,
> University of Moratuwa,
> Sri Lanka.
>
> Blog: http://nirmalfdo.blogspot.com/
>
>


-- 
Best Regards,
Nirmal

C.S.Nirmal J. Fernando
Department of Computer Science & Engineering,
Faculty of Engineering,
University of Moratuwa,
Sri Lanka.

Blog: http://nirmalfdo.blogspot.com/

Reply via email to