[ https://issues.apache.org/jira/browse/TUSCANY-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163524#comment-13163524 ]
Simon Laws commented on TUSCANY-3965: ------------------------------------- At revision: 1210860 I added some more changes to generally not detect properties/references automatically if there are @Service/@Reference/@Property annotations. This highlights some errors in the JCI tests so I've added some excludes to the JCI test suite until I can get OASIS to fix them. I'll leave this JIRA open until I can remove the excludes. > In a Service Implementation annotated with @Service, it's unannonated > properties should not be introspected > ----------------------------------------------------------------------------------------------------------- > > Key: TUSCANY-3965 > URL: https://issues.apache.org/jira/browse/TUSCANY-3965 > Project: Tuscany > Issue Type: Bug > Components: Java SCA Assembly Model > Affects Versions: Java-SCA-2.0-Beta1 > Environment: All > Reporter: Hasan Muhammad > Priority: Critical > Fix For: Java-SCA-2.x > > > I was trying to deploy a composite which has component implementing a java > implementation annotated with @Service which has the following field > @Service(TestOasis.class) > public class TestOasisImpl implements TestOasis { > @DefaultHelperContext > protected HelperContext helperContext; > This is not a property as it clearly does not have a @Property annotation and > hence the composite definition does not define this property. However, the > validation is logging this as an error as follows > [Composite: {http://docs.oasis-open.org/ns/opencsa/sca/200912}, Component: > SDOSimpleServiceJavaSerOasis] - No type specified on component property: > Component = SDOSimpleServiceJavaSerOasis Property = helperContext > This is coming from org.apache.tuscany.sca.builder.impl.ComponentBuilderImpl > and the message ID is NoTypeForComponentProperty > This validation is too strict and we should ignore properties defined in > Service class which are not annotated with @Property. The CI spec section 8.1 > appears to confirm to this deduction. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira