Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/2#discussion_r75570747
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java
---
@@ -225,5 +257,35 @@ public ContainerLiveNodeData getLiveNodeData() {
public void kill() {
processController.cancel();
}
+
+ private void killAndWait(int maxWaitSecs) {
+ try {
+ Stopwatch watch = new Stopwatch();
+ watch.start();
+ int tries = 0;
+ while (watch.elapsedTime(TimeUnit.SECONDS) < maxWaitSecs) {
--- End diff --
If we have to loop, it's better to have it inside the
`ProcessController.cancel()` method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
