Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/twill/pull/2#discussion_r75572116
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
 ---
    @@ -846,24 +875,31 @@ private boolean handleRestartRunnablesInstances(final 
Message message, final Run
       /**
        * Helper method to restart instances of runnables.
        */
    -  private void restartRunnableInstances(String runnableName, @Nullable 
Set<Integer> instanceIds) {
    +  private void restartRunnableInstances(String runnableName, @Nullable 
Set<Integer> instanceIds)
    +    throws InterruptedException {
    --- End diff --
    
    Good point, looks like I missed it during a refactor. Will remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to