[
https://issues.apache.org/jira/browse/TWILL-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447670#comment-15447670
]
ASF GitHub Bot commented on TWILL-177:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/8#discussion_r76718497
--- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/BaseYarnTest.java
---
@@ -66,6 +69,18 @@ protected void after() {
}
};
+ @Rule
+ public final TestName testName = new TestName();
+
+ @Before
+ public void beforeTest() {
+ LOG.info("Before test {}", testName.getMethodName());
--- End diff --
Why? It helps identify which parts in the log is for which test.
> ZKDiscoveryService should have a way to remove its connection watcher
> ---------------------------------------------------------------------
>
> Key: TWILL-177
> URL: https://issues.apache.org/jira/browse/TWILL-177
> Project: Apache Twill
> Issue Type: Bug
> Components: discovery
> Reporter: Albert Shau
> Assignee: Terence Yim
> Fix For: 0.8.0
>
>
> The ZKDiscoveryService adds a connection watcher in its constructor, but has
> no way to remove it. As a result, if somebody is creating new instances, the
> number of watches will slowly grow.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
