[ https://issues.apache.org/jira/browse/TWILL-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15488244#comment-15488244 ]
ASF GitHub Bot commented on TWILL-177: -------------------------------------- Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/8#discussion_r78632801 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/YarnTestSuite.java --- @@ -17,8 +17,15 @@ */ package org.apache.twill.yarn; +import org.junit.After; +import org.junit.Before; +import org.junit.Rule; +import org.junit.rules.ExternalResource; +import org.junit.rules.TestName; --- End diff -- fixed > ZKDiscoveryService should have a way to remove its connection watcher > --------------------------------------------------------------------- > > Key: TWILL-177 > URL: https://issues.apache.org/jira/browse/TWILL-177 > Project: Apache Twill > Issue Type: Bug > Components: discovery > Reporter: Albert Shau > Assignee: Terence Yim > Fix For: 0.8.0 > > > The ZKDiscoveryService adds a connection watcher in its constructor, but has > no way to remove it. As a result, if somebody is creating new instances, the > number of watches will slowly grow. -- This message was sent by Atlassian JIRA (v6.3.4#6332)