Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82036739
--- Diff:
twill-common/src/main/java/org/apache/twill/internal/Constants.java ---
@@ -78,6 +78,15 @@ private Files() {
}
}
+ /**
+ * Constants for twill environment variable names.
+ */
+ public static final class Environments {
--- End diff --
They are initially used in EnvKeys to pass system env variables. But with
the use of TwillRuntimeSpecification, they are no longer used as keys. They are
used as constants in configuration or error messages so I move them to
Constants class
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
