Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82069407
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -169,7 +172,7 @@ public Reader getInput() throws IOException {
}
private int getReservedMemory() {
- String value = System.getenv(EnvKeys.TWILL_RESERVED_MEMORY_MB);
+ String value = Integer.toString(twillRuntimeSpec.getReservedMemory());
if (value == null) {
--- End diff --
This logic doesn't make sense. The `twillRuntimeSpec.getReservedMemory`
already return an `int`. It can never be `null`. This method is unnecessary.
Just call `twillRuntimeSpec.getReservedMemory` whenever needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
