Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r86287245
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -296,8 +298,42 @@ public TwillPreparer addSecureStore(SecureStore
secureStore) {
@Override
public TwillPreparer setLogLevel(LogEntry.Level logLevel) {
+ return setRootLogLevel(logLevel);
+ }
+
+ @Override
+ public TwillPreparer setRootLogLevel(LogEntry.Level logLevel) {
Preconditions.checkNotNull(logLevel);
this.logLevel = logLevel;
+ saveLogLevels(logLevel);
+ return this;
+ }
+
+ @Override
+ public TwillPreparer setRootLogLevel(String runnableName, LogEntry.Level
logLevel) {
+ setLogLevels(runnableName, ImmutableMap.of(Logger.ROOT_LOGGER_NAME,
logLevel));
+ return this;
+ }
+
+ @Override
+ public TwillPreparer setLogLevels(Map<String, LogEntry.Level> logLevels)
{
+ Preconditions.checkNotNull(logLevels);
+ if (logLevels.containsKey(Logger.ROOT_LOGGER_NAME)) {
+ this.logLevel = logLevels.get(Logger.ROOT_LOGGER_NAME);
+ }
+ for (String runnableName : twillSpec.getRunnables().keySet()) {
+ saveLogLevels(runnableName, logLevels);
+ }
+ return this;
+ }
+
+ @Override
+ public TwillPreparer setLogLevels(String runnableName, Map<String,
LogEntry.Level> runnableLogLeves) {
--- End diff --
typo: runnableLogLevels
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
