Github user anew commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r86286972
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
 ---
    @@ -475,6 +496,11 @@ private void sendMessage(final String runnableName, 
final Message message,
         Futures.addCallback(controller.sendMessage(message), new 
FutureCallback<Message>() {
           @Override
           public void onSuccess(Message result) {
    +        //update log level information
    --- End diff --
    
    onSuccess here really means that the message has been sent to the runnable 
successfully, right? But it does not reflect the actual state of the runnable 
itself? It that on purpose?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to