Github user albertshau commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r90152039
--- Diff:
twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java ---
@@ -35,8 +35,10 @@
* Invoked when new messages is available.
* @param messages Iterator of new messages. The {@link
FetchedMessage} instance maybe reused in the Iterator
* and across different invocation.
+ * @return A long larger than zero as the offset to restart fetching
messages when offset error is caught,
--- End diff --
what happens if the offset returned is out of bounds? Should document the
expected behavior in such circumstances. Looking at the implementation, it
seems like we read from the earliest offset.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
