Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94551352
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
---
@@ -68,7 +69,7 @@
/**
* A {@link KafkaConsumer} implementation using the scala kafka api.
*/
-final class SimpleKafkaConsumer implements KafkaConsumer {
+public final class SimpleKafkaConsumer implements KafkaConsumer {
--- End diff --
That's not a good reason to turn this class to public. Why the unit test
have to use this method? Can't the unit test just return some offset that it
know of?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
