Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r91844710
  
    --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java 
---
    @@ -89,4 +90,44 @@
        * @return A {@link Future} that will be completed when the restart 
operation has been done.
        */
       Future<String> restartInstances(String runnable, int instanceId, int... 
moreInstanceIds);
    +
    +  /**
    +   * Set the root log level for Twill applications in all containers.
    +   *
    +   * @param logLevel The log level for the root logger to change.
    +   * @return A {@link Future} that will be completed when the set log 
level operation has been done. It will carry
    +   *         the log level as a result.
    +   */
    +  Future<LogEntry.Level> setRootLogLevel(LogEntry.Level logLevel);
    +
    +  /**
    +   * Set the root log level for a particular runnable.
    +   *
    +   * @param runnableName The name of the runnable to set the log level.
    +   * @param logLevel The log level for the root logger to change.
    +   * @return A {@link Future} that will be completed when the set log 
level operation has been done. It will carry
    +   *         the log level as a result.
    +   */
    +  Future<LogEntry.Level> setRootLogLevel(String runnableName, 
LogEntry.Level logLevel);
    +
    +  /**
    +   * Set the log levels for requested logger names for Twill applications 
running in a container.
    +   *
    +   * @param logLevels The {@link Map} contains the requested logger names 
and log levels that need to be set.
    +   * @return A {@link Future} that will be completed when the set log 
level operation has been done. It will carry the
    +   *         {@link Map} of log levels as the result.
    +   */
    +  Future<Map<String, LogEntry.Level>> setLogLevels(Map<String, 
LogEntry.Level> logLevels);
    --- End diff --
    
    @hsaputra I think it get removed after this comment, but this comment 
sticks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to