Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r90134835
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java ---
    @@ -197,16 +198,16 @@ protected final void shutDown() throws Exception {
         }
       }
     
    +  protected final OperationFuture<?> updateLiveNode() {
    --- End diff --
    
    Add a javadoc for protected method as it is meant to be called by the child 
class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to