[
https://issues.apache.org/jira/browse/TWILL-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858268#comment-15858268
]
Martin Serrano commented on TWILL-215:
--------------------------------------
You get a {{ClassNotFoundException}} trying to start the app master. My view
would be that a preventable error like this should be prevented since the twill
system depends on the appmaster to be able to discover any startup errors. I'm
going to submit a PR for the proposed fix (throwing an exception when the
bundle is being created) since I think the details will warrant discussion.
> Dependencies not on classpath lead to runtime startup error
> -----------------------------------------------------------
>
> Key: TWILL-215
> URL: https://issues.apache.org/jira/browse/TWILL-215
> Project: Apache Twill
> Issue Type: Bug
> Components: core
> Affects Versions: 0.9.0
> Reporter: Martin Serrano
> Priority: Critical
> Fix For: 0.10.0
>
>
> We do not use logback in our environment but it is a dependency of
> {{ApplicationMasterMain}}. When {{YarnTwillPreparer.createTwillJar}} is
> called in our environment, the logback jar is not on our classpath. For a
> class not in the classpath, the {{Dependencies.findClassDependencies}} method
> ignores it. This leads to a runtime startup error when the app master tries
> to start.
> This is easily fixed unless there some use case for ignoring the dependency
> when it is not on the classpath. An exception should be thrown and no yarn
> job should be submitted.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
