[ 
https://issues.apache.org/jira/browse/TWILL-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858607#comment-15858607
 ] 

Martin Serrano commented on TWILL-215:
--------------------------------------

The details got pretty messy.  I still think a github diff/pr is the best way 
to discuss.  Should I just submit a PR?

> Dependencies not on classpath lead to runtime startup error
> -----------------------------------------------------------
>
>                 Key: TWILL-215
>                 URL: https://issues.apache.org/jira/browse/TWILL-215
>             Project: Apache Twill
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.9.0
>            Reporter: Martin Serrano
>            Priority: Critical
>             Fix For: 0.10.0
>
>
> We do not use logback in our environment but it is a dependency of 
> {{ApplicationMasterMain}}.  When {{YarnTwillPreparer.createTwillJar}} is 
> called in our environment, the logback jar is not on our classpath.   For a 
> class not in the classpath, the {{Dependencies.findClassDependencies}} method 
> ignores it.  This leads to a runtime startup error when the app master tries 
> to start.
> This is easily fixed unless there some use case for ignoring the dependency 
> when it is not on the classpath.  An exception should be thrown and no yarn 
> job should be submitted.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to