[
https://issues.apache.org/jira/browse/TWILL-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933482#comment-15933482
]
ASF GitHub Bot commented on TWILL-225:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/39#discussion_r107007777
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -155,25 +153,16 @@ public String apply(Class<?> cls) {
private ClassAcceptor classAcceptor;
private final Map<String, Integer> maxRetries = Maps.newHashMap();
- YarnTwillPreparer(YarnConfiguration yarnConfig, TwillSpecification
twillSpec, RunId runId,
- YarnAppClient yarnAppClient, String zkConnectString,
Location appLocation, Set<URL> twillClassPaths,
+ YarnTwillPreparer(Configuration config, TwillSpecification twillSpec,
RunId runId,
--- End diff --
It's more generic. We actually not using any specific method from
`YarnConfiguration` in this class.
> Allow using different configurations per application submission
> ---------------------------------------------------------------
>
> Key: TWILL-225
> URL: https://issues.apache.org/jira/browse/TWILL-225
> Project: Apache Twill
> Issue Type: Improvement
> Reporter: Terence Yim
> Assignee: Terence Yim
> Fix For: 0.11.0
>
>
> Currently there are couple configurations that can be provided via the hadoop
> {{Configuration}} object to the {{YarnTwillRunnerService}}. However, those
> configurations are global (same for all app launched through the same
> {{TwillRunnerService}}). It would be better if the {{TwillPreparer}} exposes
> method to alter the configuration for a given app submission.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
