[ 
https://issues.apache.org/jira/browse/TWILL-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935255#comment-15935255
 ] 

ASF GitHub Bot commented on TWILL-225:
--------------------------------------

Github user anwar6953 commented on a diff in the pull request:

    https://github.com/apache/twill/pull/39#discussion_r107265236
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
    @@ -455,21 +475,40 @@ private void saveLogLevels(String runnableName, 
Map<String, LogEntry.Level> logL
         this.logLevels.put(runnableName, newLevels);
       }
     
    +  /**
    +   * Creates an {@link Credentials} by copying the {@link Credentials} of 
the current user.
    +   */
       private Credentials createCredentials() {
         Credentials credentials = new Credentials();
     
         try {
           
credentials.addAll(UserGroupInformation.getCurrentUser().getCredentials());
    +    } catch (IOException e) {
    --- End diff --
    
    I guess app submission would fail if caller doesn't acquire required 
credentials in its own way anyways.


> Allow using different configurations per application submission
> ---------------------------------------------------------------
>
>                 Key: TWILL-225
>                 URL: https://issues.apache.org/jira/browse/TWILL-225
>             Project: Apache Twill
>          Issue Type: Improvement
>            Reporter: Terence Yim
>            Assignee: Terence Yim
>             Fix For: 0.11.0
>
>
> Currently there are couple configurations that can be provided via the hadoop 
> {{Configuration}} object to the {{YarnTwillRunnerService}}. However, those 
> configurations are global (same for all app launched through the same 
> {{TwillRunnerService}}). It would be better if the {{TwillPreparer}} exposes 
> method to alter the configuration for a given app submission.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to