Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/twill/pull/40#discussion_r107771740
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -105,4 +114,17 @@ public String getRmSchedulerAddr() {
public Map<String, Integer> getMaxRetries() {
return maxRetries;
}
+
+ /**
+ * Returns the ZK connection string for the Kafka used for log
collections,
+ * or {@code null} if log collection is disabled.
+ */
+ @Nullable
+ public String getKafkaZKConnect() {
+ if (!isLogCollectionEnabled()) {
--- End diff --
Same thing of no way that caller could have guessed without looking at the
code that there is a check of isLogCollectionEnabled inside getKafkaZKConnect
that have inferred meaning when it is returning null.
The compromise I think at least added JavaDoc header for getKafkaZKConnect
to explain why it could return null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
