Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/twill/pull/40#discussion_r107788346
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillController.java ---
@@ -77,7 +77,7 @@
*/
YarnTwillController(String appName, RunId runId, ZKClient zkClient,
final ApplicationMasterLiveNodeData amLiveNodeData,
final YarnAppClient yarnAppClient) {
- super(runId, zkClient, Collections.<LogHandler>emptyList());
+ super(appName, runId, zkClient, amLiveNodeData.getKafkaZKConnect() !=
null, Collections.<LogHandler>emptyList());
--- End diff --
At this point is more about style than correctness. I personally prefer to
not make the logic of determining to enable or disable logging in
YarnTwillController but rather on object that have current state of the union.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
