[ https://issues.apache.org/jira/browse/TWILL-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939150#comment-15939150 ]
ASF GitHub Bot commented on TWILL-122: -------------------------------------- Github user hsaputra commented on a diff in the pull request: https://github.com/apache/twill/pull/40#discussion_r107771740 --- Diff: twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java --- @@ -105,4 +114,17 @@ public String getRmSchedulerAddr() { public Map<String, Integer> getMaxRetries() { return maxRetries; } + + /** + * Returns the ZK connection string for the Kafka used for log collections, + * or {@code null} if log collection is disabled. + */ + @Nullable + public String getKafkaZKConnect() { + if (!isLogCollectionEnabled()) { --- End diff -- Same thing of no way that caller could have guessed without looking at the code that there is a check of isLogCollectionEnabled inside getKafkaZKConnect that have inferred meaning when it is returning null. The compromise I think at least added JavaDoc header for getKafkaZKConnect to explain why it could return null. > Allow disabling the log transport > --------------------------------- > > Key: TWILL-122 > URL: https://issues.apache.org/jira/browse/TWILL-122 > Project: Apache Twill > Issue Type: Improvement > Components: core > Reporter: Terence Yim > Assignee: Terence Yim > Fix For: 0.11.0 > > > Currently transporting logs to Kafka is mandatory. It should be optionally so > that application can have its own way of log collection. -- This message was sent by Atlassian JIRA (v6.3.15#6346)