[
https://issues.apache.org/jira/browse/TWILL-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939256#comment-15939256
]
ASF GitHub Bot commented on TWILL-122:
--------------------------------------
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/twill/pull/40#discussion_r107788346
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillController.java ---
@@ -77,7 +77,7 @@
*/
YarnTwillController(String appName, RunId runId, ZKClient zkClient,
final ApplicationMasterLiveNodeData amLiveNodeData,
final YarnAppClient yarnAppClient) {
- super(runId, zkClient, Collections.<LogHandler>emptyList());
+ super(appName, runId, zkClient, amLiveNodeData.getKafkaZKConnect() !=
null, Collections.<LogHandler>emptyList());
--- End diff --
At this point is more about style than correctness. I personally prefer to
not make the logic of determining to enable or disable logging in
YarnTwillController but rather on object that have current state of the union.
> Allow disabling the log transport
> ---------------------------------
>
> Key: TWILL-122
> URL: https://issues.apache.org/jira/browse/TWILL-122
> Project: Apache Twill
> Issue Type: Improvement
> Components: core
> Reporter: Terence Yim
> Assignee: Terence Yim
> Fix For: 0.11.0
>
>
> Currently transporting logs to Kafka is mandatory. It should be optionally so
> that application can have its own way of log collection.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
