[ 
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113320#comment-16113320
 ] 

ASF GitHub Bot commented on TWILL-240:
--------------------------------------

Github user maochf commented on a diff in the pull request:

    https://github.com/apache/twill/pull/58#discussion_r131234842
  
    --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandler.java ---
    @@ -124,6 +124,75 @@ public void initialize(EventHandlerContext context) {
       }
     
       /**
    +   * Invoked by the application when it starts.
    +   *
    +   * @param twillAppName name of the current application
    +   * @param runId run ID of current application run
    +   */
    +  public void started(String twillAppName, RunId runId) {
    --- End diff --
    
    the `EventHandlerContext` just contains a `EventHandlerSpecification`, and 
it doesn't seem to guarantee app name and runid are there?


> Improve EventHandler to handle more application lifecycle events
> ----------------------------------------------------------------
>
>                 Key: TWILL-240
>                 URL: https://issues.apache.org/jira/browse/TWILL-240
>             Project: Apache Twill
>          Issue Type: New Feature
>            Reporter: Chengfeng Mao
>            Assignee: Chengfeng Mao
>
> Application Master should be able to run application specific code when 
> certain lifecycle events happen by calling methods from EventHandler. For 
> instance, when the app first starts, completes, aborts and etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to