[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113165#comment-16113165
]
ASF GitHub Bot commented on TWILL-240:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131212239
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/ProvisionTimeoutTestRun.java ---
@@ -79,12 +83,22 @@ public void initialize(EventHandlerContext context) {
@Override
public TimeoutAction launchTimeout(Iterable<TimeoutEvent>
timeoutEvents) {
+ for (TimeoutEvent event : timeoutEvents) {
+ LOG.info("Requested {} containers for runnable {}, only got {}
after {} ms.",
+ event.getExpectedInstances(), event.getRunnableName(),
+ event.getActualInstances(), System.currentTimeMillis() -
event.getRequestTime());
+ }
if (abort) {
return TimeoutAction.abort();
} else {
return TimeoutAction.recheck(10, TimeUnit.SECONDS);
}
}
+
+ @Override
+ public void aborted(String twillAppName, RunId runId) {
+ LOG.info(String.format("Aborted %s with runId %s", twillAppName,
runId.getId()));
--- End diff --
Besides logging, can you add/modify the test to actually validate the new
lifecycle methods in the EventHandler?
> Improve EventHandler to handle more application lifecycle events
> ----------------------------------------------------------------
>
> Key: TWILL-240
> URL: https://issues.apache.org/jira/browse/TWILL-240
> Project: Apache Twill
> Issue Type: New Feature
> Reporter: Chengfeng Mao
> Assignee: Chengfeng Mao
>
> Application Master should be able to run application specific code when
> certain lifecycle events happen by calling methods from EventHandler. For
> instance, when the app first starts, completes, aborts and etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
