Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132322087
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -181,19 +190,130 @@ public Reader getInput() throws IOException {
}
@SuppressWarnings("unchecked")
- @Nullable
private EventHandler createEventHandler(TwillSpecification twillSpec)
throws ClassNotFoundException {
// Should be able to load by this class ClassLoader, as they packaged
in the same jar.
EventHandlerSpecification handlerSpec = twillSpec.getEventHandler();
if (handlerSpec == null) {
- return null;
+ // if no handler is specified, return an EventHandler with no-op
+ return new EventHandler() {};
}
Class<?> handlerClass =
getClass().getClassLoader().loadClass(handlerSpec.getClassName());
Preconditions.checkArgument(EventHandler.class.isAssignableFrom(handlerClass),
"Class {} does not implements {}",
handlerClass,
EventHandler.class.getName());
- return Instances.newInstance((Class<? extends EventHandler>)
handlerClass);
+ final EventHandler delegate = Instances.newInstance((Class<? extends
EventHandler>) handlerClass);
+ // wrap all calls to the delegate EventHandler methods except
initialize so that all errors will be caught
+ return new EventHandler() {
+ private boolean initialized;
+
+ @Override
+ public void initialize(EventHandlerContext context) {
+ delegate.initialize(context);
+ initialized = true;
--- End diff --
Since any exception thrown from `initialize` will terminate the app, I
think we don't need this, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
