Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132322316
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -239,14 +359,8 @@ protected void doStop() throws Exception {
LOG.info("Stop application master with spec: {}",
TwillRuntimeSpecificationAdapter.create().toJson(twillRuntimeSpec));
- if (eventHandler != null) {
- try {
- // call event handler destroy. If there is error, only log and not
affected stop sequence.
- eventHandler.destroy();
- } catch (Throwable t) {
- LOG.warn("Exception when calling {}.destroy()",
eventHandler.getClass().getName(), t);
- }
- }
+ // call event handler destroy
+ eventHandler.destroy();
--- End diff --
Shouldn't call `destroy()` here anymore. It should be called after call
other calls to the event handler, as it is acted as a cleanup call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
