----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19151/#review36967 -----------------------------------------------------------
pom.xml <https://reviews.apache.org/r/19151/#comment68167> Should example built as a sub-module or should it be a separate maven project that depends on twill? twill-examples/.gitignore <https://reviews.apache.org/r/19151/#comment68168> You can add a configuration to the shade plugin to disable generation of the dependency-reduced-pom.xml <createDependencyReducedPom>false</createDependencyReducedPom> twill-examples/pom.xml <https://reviews.apache.org/r/19151/#comment68169> What the profile is for? twill-examples/src/main/java/org/apache/twill/yarn/HelloWorld.java <https://reviews.apache.org/r/19151/#comment68170> Missing javadoc. twill-examples/src/main/java/org/apache/twill/yarn/HelloWorld.java <https://reviews.apache.org/r/19151/#comment68171> Missing Javadoc. twill-examples/src/main/java/org/apache/twill/yarn/HelloWorld.java <https://reviews.apache.org/r/19151/#comment68172> If there is only one runnable, this app is not needed. twill-examples/src/main/java/org/apache/twill/yarn/HelloWorld.java <https://reviews.apache.org/r/19151/#comment68178> Wrong alignment. twill-examples/src/main/java/org/apache/twill/yarn/HelloWorld.java <https://reviews.apache.org/r/19151/#comment68179> Ideally there is a try-finally block to stop the twillRunner when main exit. twill-examples/src/main/java/org/apache/twill/yarn/JarRunnerExample.java <https://reviews.apache.org/r/19151/#comment68173> Missing javadoc. twill-examples/src/main/java/org/apache/twill/yarn/JarRunnerExample.java <https://reviews.apache.org/r/19151/#comment68177> Wouldn't it better to have the example main takes a bundle jar file from the argument? Also, we don't want to provide bundled.jar binary in the source, as this complicated licensing. However, you could have another project that contains the source to create a bundle jar. twill-ext/pom.xml <https://reviews.apache.org/r/19151/#comment68181> Version should be inherited from parent pom, hence shouldn't be specified here. twill-ext/src/main/java/org/apache/twill/ext/BundledJarApplication.java <https://reviews.apache.org/r/19151/#comment68182> Missing javadoc. twill-ext/src/main/java/org/apache/twill/ext/BundledJarApplication.java <https://reviews.apache.org/r/19151/#comment68183> What is it trying to do? When the bundled jar path has to be in classpath? twill-ext/src/main/java/org/apache/twill/ext/BundledJarApplication.java <https://reviews.apache.org/r/19151/#comment68210> I think it's better to have the runnable wrapper passes runtime argument to the main method of the target class rather than using configuration time configs as arguments provided to main method. twill-ext/src/main/java/org/apache/twill/ext/BundledJarApplication.java <https://reviews.apache.org/r/19151/#comment68208> Child class should be able to specify resource spec per runnable and 128MB seems too low as default anyway. twill-ext/src/main/java/org/apache/twill/ext/BundledJarApplication.java <https://reviews.apache.org/r/19151/#comment68196> Use Preconditions.checkArgument twill-ext/src/main/java/org/apache/twill/ext/BundledJarApplication.java <https://reviews.apache.org/r/19151/#comment68207> I think it's better to use TwillRunnableSpecification and ResourceSpecification instead of creating new spec. twill-ext/src/main/java/org/apache/twill/ext/BundledJarApplication.java <https://reviews.apache.org/r/19151/#comment68209> What is this for? - Terence Yim On March 12, 2014, 8:14 p.m., Jiahua Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19151/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 8:14 p.m.) > > > Review request for Twill. > > > Repository: twill > > > Description > ------- > > Implement a TwillApplication that runs bundled jars. This is to allow user > programs to run without having to worry about dependency conflicts with > Twill. For example, Presto uses Guava 16 whereas Twill uses Guava 13, so they > can't run in the same class loader. > > See JarRunnerExample (in twill-examples) for example usage of > BundledJarApplication (in twill-ext). > > > Diffs > ----- > > pom.xml 8e93850 > twill-examples/.gitignore PRE-CREATION > twill-examples/pom.xml PRE-CREATION > twill-examples/src/main/java/org/apache/twill/yarn/HelloWorld.java > PRE-CREATION > twill-examples/src/main/java/org/apache/twill/yarn/JarRunnerExample.java > PRE-CREATION > twill-examples/src/main/resources/org/apache/twill/yarn/bundled.jar.keep > PRE-CREATION > twill-ext/pom.xml PRE-CREATION > twill-ext/src/main/java/org/apache/twill/ext/BundledJarApplication.java > PRE-CREATION > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunnable.java > PRE-CREATION > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunner.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19151/diff/ > > > Testing > ------- > > Tested JarRunnerExample on a single node cluster. Also tested a Twill > application that starts up multiple runnables that run Presto services. > > > Thanks, > > Jiahua Wang > >
